What
Two whole configuration blocks are in the schema and the web UI form, and no code reads either of them. Counting reads of each top-level block across the plugin's Python:
block reads leaves
enabled 3 1
display_duration 2 1
...
display_modes 9 29
notifications 0 8
branding 0 4
Neither config.get("notifications") nor config.get("branding") appears anywhere in the plugin, and neither is read by the core.
The README documents both as features, with their own sections — Notifications and Branding Options — describing alerts that interrupt the display and toggles for the Masters logo, the green jacket, the azaleas and a colour scheme.
The dead settings
notifications (8): practice_round_alerts.enabled, practice_round_alerts.interrupt_display, favorite_player_alerts.enabled, favorite_player_alerts.interrupt_display, tournament_start_alert.enabled, tournament_start_alert.interrupt_display, and the two remaining leaves in that block.
branding (4): show_masters_logo, show_green_jacket, show_azaleas, color_scheme.
Five more inside display_modes, where the block is read but these particular leaves are not: player_cards.show_headshots, player_cards.duration_per_player, course_tour.show_animations, course_tour.duration_per_hole, course_tour.featured_holes.
That is 17 of the plugin's 51 settings.
One that looks dead and is not
For contrast, display_modes.<mode>.enabled never appears as a literal for most modes — it is read generically:
config_key = config_key_map.get(mode)
mode_config = display_modes_config.get(config_key, {})
if mode_config.get("enabled", True):so every mode's enabled is live. I checked this before assuming, after cricket-scoreboard turned out to read mode_durations through a runtime-built key (see #416).
Similarly featured_holes appears six times in the source — but every one is the display mode name masters_featured_holes, not the course_tour.featured_holes config key. That key is dead.
Options
Implement, remove, or mark. The accompanying README PR marks all 17 and links here, so the documentation stops describing behaviour that does not happen; whether the branding and notification features were abandoned or never finished is your call.
What
Two whole configuration blocks are in the schema and the web UI form, and no code reads either of them. Counting reads of each top-level block across the plugin's Python:
Neither
config.get("notifications")norconfig.get("branding")appears anywhere in the plugin, and neither is read by the core.The README documents both as features, with their own sections — Notifications and Branding Options — describing alerts that interrupt the display and toggles for the Masters logo, the green jacket, the azaleas and a colour scheme.
The dead settings
notifications(8):practice_round_alerts.enabled,practice_round_alerts.interrupt_display,favorite_player_alerts.enabled,favorite_player_alerts.interrupt_display,tournament_start_alert.enabled,tournament_start_alert.interrupt_display, and the two remaining leaves in that block.branding(4):show_masters_logo,show_green_jacket,show_azaleas,color_scheme.Five more inside
display_modes, where the block is read but these particular leaves are not:player_cards.show_headshots,player_cards.duration_per_player,course_tour.show_animations,course_tour.duration_per_hole,course_tour.featured_holes.That is 17 of the plugin's 51 settings.
One that looks dead and is not
For contrast,
display_modes.<mode>.enablednever appears as a literal for most modes — it is read generically:so every mode's
enabledis live. I checked this before assuming, aftercricket-scoreboardturned out to readmode_durationsthrough a runtime-built key (see #416).Similarly
featured_holesappears six times in the source — but every one is the display mode namemasters_featured_holes, not thecourse_tour.featured_holesconfig key. That key is dead.Options
Implement, remove, or mark. The accompanying README PR marks all 17 and links here, so the documentation stops describing behaviour that does not happen; whether the branding and notification features were abandoned or never finished is your call.