Skip to content

[static-image] rotation_mode "date_based" is a stub that always shows the first image #372

Description

@ChuckBuilds

Plugin

  • Plugin id: static-image
  • Plugin version: 1.0.5

Describe the bug

image_config.rotation_mode offers four values in the schema, and one of them does nothing. date_based is a placeholder that returns the first available image every time:

elif self.rotation_mode == 'date_based':
    # Future implementation
    return available_images[0]

The option is presented in the web UI alongside the three that work, so selecting it looks like a broken rotation rather than an unimplemented feature. There is no log line either — the display simply never advances.

Steps to reproduce

  1. Configure two or more images with image_config.mode: "multiple".
  2. Set image_config.rotation_mode: "date_based".
  3. The first image shows indefinitely.

Related: time_based needs a second switch

Not a bug, but the same class of confusion and worth considering together. rotation_mode: "time_based" does nothing on its own — rotation_settings.time_intervals.enabled must also be true, or the image never advances. Two settings that have to agree, with no feedback when they do not.

Suggested fix

Either implement date-based selection (day-of-year indexing, the way of-the-day picks its entry, would fit), or drop date_based from the schema enum until it exists. Removing it cannot break a working configuration, since no configuration using it works today.

For time_based, the switch could be implied by the mode rather than requiring both.

Documented as a known limitation in #367 in the meantime.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions