Plugin
- Plugin id: static-image
- Plugin version: 1.0.5
Describe the bug
image_config.rotation_mode offers four values in the schema, and one of them does nothing. date_based is a placeholder that returns the first available image every time:
elif self.rotation_mode == 'date_based':
# Future implementation
return available_images[0]
The option is presented in the web UI alongside the three that work, so selecting it looks like a broken rotation rather than an unimplemented feature. There is no log line either — the display simply never advances.
Steps to reproduce
- Configure two or more images with
image_config.mode: "multiple".
- Set
image_config.rotation_mode: "date_based".
- The first image shows indefinitely.
Related: time_based needs a second switch
Not a bug, but the same class of confusion and worth considering together. rotation_mode: "time_based" does nothing on its own — rotation_settings.time_intervals.enabled must also be true, or the image never advances. Two settings that have to agree, with no feedback when they do not.
Suggested fix
Either implement date-based selection (day-of-year indexing, the way of-the-day picks its entry, would fit), or drop date_based from the schema enum until it exists. Removing it cannot break a working configuration, since no configuration using it works today.
For time_based, the switch could be implied by the mode rather than requiring both.
Documented as a known limitation in #367 in the meantime.
Plugin
Describe the bug
image_config.rotation_modeoffers four values in the schema, and one of them does nothing.date_basedis a placeholder that returns the first available image every time:The option is presented in the web UI alongside the three that work, so selecting it looks like a broken rotation rather than an unimplemented feature. There is no log line either — the display simply never advances.
Steps to reproduce
image_config.mode: "multiple".image_config.rotation_mode: "date_based".Related:
time_basedneeds a second switchNot a bug, but the same class of confusion and worth considering together.
rotation_mode: "time_based"does nothing on its own —rotation_settings.time_intervals.enabledmust also betrue, or the image never advances. Two settings that have to agree, with no feedback when they do not.Suggested fix
Either implement date-based selection (day-of-year indexing, the way
of-the-daypicks its entry, would fit), or dropdate_basedfrom the schema enum until it exists. Removing it cannot break a working configuration, since no configuration using it works today.For
time_based, the switch could be implied by the mode rather than requiring both.Documented as a known limitation in #367 in the meantime.