From 94dc2b12b3667e8fc13b48fbf2d818f6a549bc22 Mon Sep 17 00:00:00 2001 From: Nikolay Vitkov Date: Wed, 25 Mar 2026 15:41:20 +0100 Subject: [PATCH 1/2] chore: fix some typos --- src/McpResponse.ts | 6 +++--- src/PageCollector.ts | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/McpResponse.ts b/src/McpResponse.ts index b6162c27c..12a0605df 100644 --- a/src/McpResponse.ts +++ b/src/McpResponse.ts @@ -165,10 +165,10 @@ export class McpResponse implements Response { } attachNetworkRequest( - reqid: number, + reqId: number, options?: {requestFilePath?: string; responseFilePath?: string}, ): void { - this.#attachedNetworkRequestId = reqid; + this.#attachedNetworkRequestId = reqId; this.#attachedNetworkRequestOptions = options; } @@ -346,7 +346,7 @@ export class McpResponse implements Response { }); if (!formatter.isValid()) { throw new Error( - "Can't provide detals for the msgid " + consoleMessageStableId, + "Can't provide details for the msgid " + consoleMessageStableId, ); } detailedConsoleMessage = formatter; diff --git a/src/PageCollector.ts b/src/PageCollector.ts index 8a419fc62..d943baa54 100644 --- a/src/PageCollector.ts +++ b/src/PageCollector.ts @@ -272,13 +272,13 @@ class PageEventSubscriber { if (this.#issueAggregator) { this.#issueAggregator.removeEventListener( DevTools.IssueAggregatorEvents.AGGREGATED_ISSUE_UPDATED, - this.#onAggregatedissue, + this.#onAggregatedIssue, ); } this.#issueAggregator = new DevTools.IssueAggregator(this.#issueManager); this.#issueAggregator.addEventListener( DevTools.IssueAggregatorEvents.AGGREGATED_ISSUE_UPDATED, - this.#onAggregatedissue, + this.#onAggregatedIssue, ); } @@ -303,7 +303,7 @@ class PageEventSubscriber { if (this.#issueAggregator) { this.#issueAggregator.removeEventListener( DevTools.IssueAggregatorEvents.AGGREGATED_ISSUE_UPDATED, - this.#onAggregatedissue, + this.#onAggregatedIssue, ); } void this.#session.send('Audits.disable').catch(() => { @@ -311,7 +311,7 @@ class PageEventSubscriber { }); } - #onAggregatedissue = ( + #onAggregatedIssue = ( event: DevTools.Common.EventTarget.EventTargetEvent, ) => { if (this.#seenIssues.has(event.data)) { From 3079d554eab70db22f4ef29eb3d8e046f431776e Mon Sep 17 00:00:00 2001 From: Nikolay Vitkov Date: Thu, 26 Mar 2026 12:57:39 +0100 Subject: [PATCH 2/2] fix test --- tests/McpResponse.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/McpResponse.test.ts b/tests/McpResponse.test.ts index e2db88c50..7b2964d53 100644 --- a/tests/McpResponse.test.ts +++ b/tests/McpResponse.test.ts @@ -619,7 +619,7 @@ describe('McpResponse', () => { try { await response.handle('test', context); } catch (e) { - assert.ok(e.message.includes("Can't provide detals for the msgid 1")); + assert.ok(e.message.includes("Can't provide details for the msgid 1")); } }); });