Address CodeRabbit actionable review feedback

Author: Jaben

src/Gotenberg.Sharp.Api.Client/Domain/Builders/Faceted/HtmlConversionBehaviorBuilder.cs

@@ -231,11 +231,16 @@ public HtmlConversionBehaviorBuilder AddEmulatedMediaFeature(string name, string
     /// </summary>
     /// <param name="statusCodes">Validated HTTP status codes.</param>
     /// <returns>The builder instance for method chaining.</returns>
-    public HtmlConversionBehaviorBuilder SetFailOnHttpStatusCodes(IEnumerable<HttpStatusCode> statusCodes)
+    public HtmlConversionBehaviorBuilder SetFailOnHttpStatusCodes(IEnumerable<GotenbergStatusCode> statusCodes)
     {
         if (statusCodes == null) throw new ArgumentNullException(nameof(statusCodes));
 
-        _htmlConversionBehaviors.FailOnHttpStatusCodes = statusCodes.ToList();
+        var codes = statusCodes.ToList();
+
+        if (codes.Any(c => c == null))
+            throw new ArgumentException("Status codes collection must not contain null elements.", nameof(statusCodes));
+
+        _htmlConversionBehaviors.FailOnHttpStatusCodes = codes;
 
         return this;
     }
@@ -247,19 +252,26 @@ public HtmlConversionBehaviorBuilder SetFailOnHttpStatusCodes(IEnumerable<HttpSt
     /// <returns>The builder instance for method chaining.</returns>
     public HtmlConversionBehaviorBuilder SetFailOnHttpStatusCodes(params int[] statusCodes)
     {
-        return SetFailOnHttpStatusCodes(statusCodes.Select(HttpStatusCode.Create));
+        if (statusCodes == null) throw new ArgumentNullException(nameof(statusCodes));
+
+        return SetFailOnHttpStatusCodes(statusCodes.Select(GotenbergStatusCode.Create));
     }
 
     /// <summary>
     /// Sets HTTP status codes that trigger a failure when page resources return them.
     /// </summary>
     /// <param name="statusCodes">Validated HTTP status codes.</param>
     /// <returns>The builder instance for method chaining.</returns>
-    public HtmlConversionBehaviorBuilder SetFailOnResourceHttpStatusCodes(IEnumerable<HttpStatusCode> statusCodes)
+    public HtmlConversionBehaviorBuilder SetFailOnResourceHttpStatusCodes(IEnumerable<GotenbergStatusCode> statusCodes)
     {
         if (statusCodes == null) throw new ArgumentNullException(nameof(statusCodes));
 
-        _htmlConversionBehaviors.FailOnResourceHttpStatusCodes = statusCodes.ToList();
+        var codes = statusCodes.ToList();
+
+        if (codes.Any(c => c == null))
+            throw new ArgumentException("Status codes collection must not contain null elements.", nameof(statusCodes));
+
+        _htmlConversionBehaviors.FailOnResourceHttpStatusCodes = codes;
 
         return this;
     }
@@ -271,7 +283,9 @@ public HtmlConversionBehaviorBuilder SetFailOnResourceHttpStatusCodes(IEnumerabl
     /// <returns>The builder instance for method chaining.</returns>
     public HtmlConversionBehaviorBuilder SetFailOnResourceHttpStatusCodes(params int[] statusCodes)
     {
-        return SetFailOnResourceHttpStatusCodes(statusCodes.Select(HttpStatusCode.Create));
+        if (statusCodes == null) throw new ArgumentNullException(nameof(statusCodes));
+
+        return SetFailOnResourceHttpStatusCodes(statusCodes.Select(GotenbergStatusCode.Create));
     }
 
     /// <summary>
@@ -306,10 +320,12 @@ public HtmlConversionBehaviorBuilder AddIgnoreResourceHttpStatusDomain(string do
     /// <returns>The builder instance for method chaining.</returns>
     public HtmlConversionBehaviorBuilder AddIgnoreResourceHttpStatusDomains(params string[] domains)
     {
-        foreach (var domain in domains)
-        {
-            AddIgnoreResourceHttpStatusDomain(domain);
-        }
+        if (domains == null) throw new ArgumentNullException(nameof(domains));
+
+        var validated = domains.Select(DomainName.Create).ToList();
+
+        _htmlConversionBehaviors.IgnoreResourceHttpStatusDomains ??= new List<DomainName>();
+        _htmlConversionBehaviors.IgnoreResourceHttpStatusDomains.AddRange(validated);
 
         return this;
     }

src/Gotenberg.Sharp.Api.Client/Domain/Requests/Facets/FacetBase.cs

@@ -82,7 +82,7 @@ public virtual IEnumerable<HttpContent> ToHttpContent()
             List<Cookie> cookies => JsonConvert.SerializeObject(cookies),
             List<EmulatedMediaFeature> features => JsonConvert.SerializeObject(
                 features.ToDictionary(f => f.Name, f => f.Value)),
-            List<HttpStatusCode> codes => JsonConvert.SerializeObject(codes.Select(c => c.Value)),
+            List<GotenbergStatusCode> codes => JsonConvert.SerializeObject(codes.Select(c => c.Value)),
             List<DomainName> domains => JsonConvert.SerializeObject(domains.Select(d => d.Value)),
             CssSelector selector => selector.Value,
             float f => f.ToString(cultureInfo),

src/Gotenberg.Sharp.Api.Client/Domain/Requests/Facets/HtmlConversionBehaviors.cs

@@ -106,14 +106,14 @@ public class HtmlConversionBehaviors : FacetBase
     /// when the main page returns a matching code. Default: [499, 599].
     /// </summary>
     [MultiFormHeader(Constants.Gotenberg.Chromium.Shared.HtmlConvert.FailOnHttpStatusCodes)]
-    public List<HttpStatusCode>? FailOnHttpStatusCodes { get; set; }
+    public List<GotenbergStatusCode>? FailOnHttpStatusCodes { get; set; }
 
     /// <summary>
     /// HTTP status codes that trigger a failure when page resources (CSS, images, fonts)
     /// return a matching code.
     /// </summary>
     [MultiFormHeader(Constants.Gotenberg.Chromium.Shared.HtmlConvert.FailOnResourceHttpStatusCodes)]
-    public List<HttpStatusCode>? FailOnResourceHttpStatusCodes { get; set; }
+    public List<GotenbergStatusCode>? FailOnResourceHttpStatusCodes { get; set; }
 
     /// <summary>
     /// Domains to exclude from HTTP status code checks on resources.

src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/CssSelector.cs

@@ -49,7 +49,7 @@ public static CssSelector Create(string selector)
 
     public override int GetHashCode() => Value.GetHashCode();
 
-    public static implicit operator string(CssSelector selector) => selector.Value;
+    public static implicit operator string(CssSelector selector) => selector?.Value!;
 
     public static bool operator ==(CssSelector? left, CssSelector? right) => Equals(left, right);
 

src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/DomainName.cs

@@ -50,7 +50,7 @@ public bool Equals(DomainName? other) => other is not null
 
     public override int GetHashCode() => StringComparer.OrdinalIgnoreCase.GetHashCode(Value);
 
-    public static implicit operator string(DomainName domain) => domain.Value;
+    public static implicit operator string(DomainName domain) => domain?.Value!;
 
     public static bool operator ==(DomainName? left, DomainName? right) => Equals(left, right);
 

src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/EmulatedMediaFeature.cs

@@ -59,17 +59,36 @@ public static EmulatedMediaFeature Create(string name, string value)
         return new EmulatedMediaFeature(name, value);
     }
 
+    private static readonly string[] ValidColorSchemes = { "light", "dark" };
+    private static readonly string[] ValidReducedMotionValues = { "no-preference", "reduce" };
+
     /// <summary>
     /// Creates a "prefers-color-scheme" media feature.
     /// </summary>
     /// <param name="scheme">The color scheme value: "light" or "dark".</param>
-    public static EmulatedMediaFeature PrefersColorScheme(string scheme) =>
-        Create("prefers-color-scheme", scheme);
+    /// <exception cref="ArgumentException">Thrown when scheme is not "light" or "dark".</exception>
+    public static EmulatedMediaFeature PrefersColorScheme(string scheme)
+    {
+        if (!ValidColorSchemes.Contains(scheme, StringComparer.Ordinal))
+            throw new ArgumentException(
+                $"prefers-color-scheme must be 'light' or 'dark', but got '{scheme}'.",
+                nameof(scheme));
+
+        return Create("prefers-color-scheme", scheme);
+    }
 
     /// <summary>
     /// Creates a "prefers-reduced-motion" media feature.
     /// </summary>
     /// <param name="value">The value: "no-preference" or "reduce".</param>
-    public static EmulatedMediaFeature PrefersReducedMotion(string value) =>
-        Create("prefers-reduced-motion", value);
+    /// <exception cref="ArgumentException">Thrown when value is not "no-preference" or "reduce".</exception>
+    public static EmulatedMediaFeature PrefersReducedMotion(string value)
+    {
+        if (!ValidReducedMotionValues.Contains(value, StringComparer.Ordinal))
+            throw new ArgumentException(
+                $"prefers-reduced-motion must be 'no-preference' or 'reduce', but got '{value}'.",
+                nameof(value));
+
+        return Create("prefers-reduced-motion", value);
+    }
 }

…nt/Domain/ValueObjects/HttpStatusCode.cs …main/ValueObjects/GotenbergStatusCode.cssrc/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/HttpStatusCode.cs renamed to src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/GotenbergStatusCode.cs src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/HttpStatusCode.cs renamed to src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/GotenbergStatusCode.cs

@@ -25,14 +25,14 @@ namespace Gotenberg.Sharp.API.Client.Domain.ValueObjects;
 /// Gotenberg uses these as range boundaries. For example, [499, 599] means
 /// "fail on any status code from 499 to 599 inclusive."
 /// </remarks>
-public sealed class HttpStatusCode : IEquatable<HttpStatusCode>, IComparable<HttpStatusCode>
+public sealed class GotenbergStatusCode : IEquatable<GotenbergStatusCode>, IComparable<GotenbergStatusCode>
 {
     public const int MinValue = 100;
     public const int MaxValue = 599;
 
     public int Value { get; }
 
-    private HttpStatusCode(int value)
+    private GotenbergStatusCode(int value)
     {
         Value = value;
     }
@@ -42,30 +42,30 @@ private HttpStatusCode(int value)
     /// </summary>
     /// <param name="statusCode">An HTTP status code between 100 and 599 inclusive.</param>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when statusCode is outside valid range.</exception>
-    public static HttpStatusCode Create(int statusCode)
+    public static GotenbergStatusCode Create(int statusCode)
     {
         if (statusCode < MinValue || statusCode > MaxValue)
             throw new ArgumentOutOfRangeException(
                 nameof(statusCode),
                 statusCode,
                 $"HTTP status code must be between {MinValue} and {MaxValue}.");
 
-        return new HttpStatusCode(statusCode);
+        return new GotenbergStatusCode(statusCode);
     }
 
     public override string ToString() => Value.ToString(CultureInfo.InvariantCulture);
 
-    public bool Equals(HttpStatusCode? other) => other is not null && Value == other.Value;
+    public bool Equals(GotenbergStatusCode? other) => other is not null && Value == other.Value;
 
-    public override bool Equals(object? obj) => Equals(obj as HttpStatusCode);
+    public override bool Equals(object? obj) => Equals(obj as GotenbergStatusCode);
 
     public override int GetHashCode() => Value;
 
-    public int CompareTo(HttpStatusCode? other) => other is null ? 1 : Value.CompareTo(other.Value);
+    public int CompareTo(GotenbergStatusCode? other) => other is null ? 1 : Value.CompareTo(other.Value);
 
-    public static implicit operator int(HttpStatusCode code) => code.Value;
+    public static implicit operator int(GotenbergStatusCode code) => code?.Value ?? 0;
 
-    public static bool operator ==(HttpStatusCode? left, HttpStatusCode? right) => Equals(left, right);
+    public static bool operator ==(GotenbergStatusCode? left, GotenbergStatusCode? right) => Equals(left, right);
 
-    public static bool operator !=(HttpStatusCode? left, HttpStatusCode? right) => !Equals(left, right);
+    public static bool operator !=(GotenbergStatusCode? left, GotenbergStatusCode? right) => !Equals(left, right);
 }

test/GotenbergSharpClient.Tests/ChromiumMissingFieldsTests.cs

@@ -189,10 +189,10 @@ public async Task FailOnHttpStatusCodes_SerializesToIntArray()
     {
         var behaviors = new HtmlConversionBehaviors
         {
-            FailOnHttpStatusCodes = new List<HttpStatusCode>
+            FailOnHttpStatusCodes = new List<GotenbergStatusCode>
             {
-                HttpStatusCode.Create(499),
-                HttpStatusCode.Create(599)
+                GotenbergStatusCode.Create(499),
+                GotenbergStatusCode.Create(599)
             }
         };
 
@@ -214,10 +214,10 @@ public async Task FailOnResourceHttpStatusCodes_SerializesToIntArray()
     {
         var behaviors = new HtmlConversionBehaviors
         {
-            FailOnResourceHttpStatusCodes = new List<HttpStatusCode>
+            FailOnResourceHttpStatusCodes = new List<GotenbergStatusCode>
             {
-                HttpStatusCode.Create(400),
-                HttpStatusCode.Create(500)
+                GotenbergStatusCode.Create(400),
+                GotenbergStatusCode.Create(500)
             }
         };
 

…ests/ValueObjects/HttpStatusCodeTests.cs …ValueObjects/GotenbergStatusCodeTests.cstest/GotenbergSharpClient.Tests/ValueObjects/HttpStatusCodeTests.cs renamed to test/GotenbergSharpClient.Tests/ValueObjects/GotenbergStatusCodeTests.cs test/GotenbergSharpClient.Tests/ValueObjects/HttpStatusCodeTests.cs renamed to test/GotenbergSharpClient.Tests/ValueObjects/GotenbergStatusCodeTests.cs

@@ -3,7 +3,7 @@
 namespace GotenbergSharpClient.Tests.ValueObjects;
 
 [TestFixture]
-public class HttpStatusCodeTests
+public class GotenbergStatusCodeTests
 {
     [TestCase(100)]
     [TestCase(200)]
@@ -12,7 +12,7 @@ public class HttpStatusCodeTests
     [TestCase(599)]
     public void Create_WithValidStatusCode_ReturnsInstance(int code)
     {
-        var statusCode = HttpStatusCode.Create(code);
+        var statusCode = GotenbergStatusCode.Create(code);
 
         statusCode.Value.Should().Be(code);
     }
@@ -24,15 +24,15 @@ public void Create_WithValidStatusCode_ReturnsInstance(int code)
     [TestCase(1000)]
     public void Create_WithOutOfRangeCode_ThrowsArgumentOutOfRangeException(int code)
     {
-        var act = () => HttpStatusCode.Create(code);
+        var act = () => GotenbergStatusCode.Create(code);
 
         act.Should().ThrowExactly<ArgumentOutOfRangeException>();
     }
 
     [Test]
     public void ImplicitConversion_ToIntReturnsValue()
     {
-        var statusCode = HttpStatusCode.Create(404);
+        var statusCode = GotenbergStatusCode.Create(404);
         int result = statusCode;
 
         result.Should().Be(404);
@@ -41,8 +41,8 @@ public void ImplicitConversion_ToIntReturnsValue()
     [Test]
     public void Equals_WithSameValue_ReturnsTrue()
     {
-        var a = HttpStatusCode.Create(499);
-        var b = HttpStatusCode.Create(499);
+        var a = GotenbergStatusCode.Create(499);
+        var b = GotenbergStatusCode.Create(499);
 
         a.Should().Be(b);
         (a == b).Should().BeTrue();
@@ -51,8 +51,8 @@ public void Equals_WithSameValue_ReturnsTrue()
     [Test]
     public void CompareTo_OrdersCorrectly()
     {
-        var low = HttpStatusCode.Create(200);
-        var high = HttpStatusCode.Create(500);
+        var low = GotenbergStatusCode.Create(200);
+        var high = GotenbergStatusCode.Create(500);
 
         low.CompareTo(high).Should().BeNegative();
         high.CompareTo(low).Should().BePositive();
@@ -62,7 +62,7 @@ public void CompareTo_OrdersCorrectly()
     [Test]
     public void ToString_ReturnsInvariantString()
     {
-        var statusCode = HttpStatusCode.Create(404);
+        var statusCode = GotenbergStatusCode.Create(404);
 
         statusCode.ToString().Should().Be("404");
     }