Address CodeRabbit review feedback

Author: Jaben

examples/LibreOfficeOptions/Program.cs

@@ -22,12 +22,12 @@
 
 static async Task<string> ConvertWithLibreOfficeOptions(string sourceDirectory, string destinationDirectory, GotenbergSharpClientOptions options)
 {
-    using var handler = new HttpClientHandler();
-    using var authHandler = !string.IsNullOrWhiteSpace(options.BasicAuthUsername) && !string.IsNullOrWhiteSpace(options.BasicAuthPassword)
-        ? new BasicAuthHandler(options.BasicAuthUsername, options.BasicAuthPassword) { InnerHandler = handler }
-        : null;
+    var handler = new HttpClientHandler();
+    HttpMessageHandler effectiveHandler = handler;
+    if (!string.IsNullOrWhiteSpace(options.BasicAuthUsername) && !string.IsNullOrWhiteSpace(options.BasicAuthPassword))
+        effectiveHandler = new BasicAuthHandler(options.BasicAuthUsername, options.BasicAuthPassword) { InnerHandler = handler };
 
-    using var httpClient = new HttpClient(authHandler ?? (HttpMessageHandler)handler)
+    using var httpClient = new HttpClient(effectiveHandler, disposeHandler: true)
     {
         BaseAddress = options.ServiceUrl,
         Timeout = options.TimeOut

test/GotenbergSharpClient.Tests/LibreOfficeOptionsTests.cs

@@ -191,7 +191,7 @@ public void SetLibreOfficeOptions_InvalidResolution_Throws()
     #region Serialization Tests
 
     [Test]
-    public void LibreOfficeOptions_SerializesAllSetFields()
+    public async Task LibreOfficeOptions_SerializesAllSetFields()
     {
         var options = new LibreOfficeOptions
         {
@@ -205,15 +205,15 @@ public void LibreOfficeOptions_SerializesAllSetFields()
 
         httpContents.FirstOrDefault(c =>
             c.Headers.ContentDisposition?.Name == "singlePageSheets").Should().NotBeNull();
-        httpContents.FirstOrDefault(c =>
+        (await httpContents.FirstOrDefault(c =>
             c.Headers.ContentDisposition?.Name == "quality")!
-            .ReadAsStringAsync().Result.Should().Be("75");
-        httpContents.FirstOrDefault(c =>
+            .ReadAsStringAsync()).Should().Be("75");
+        (await httpContents.FirstOrDefault(c =>
             c.Headers.ContentDisposition?.Name == "maxImageResolution")!
-            .ReadAsStringAsync().Result.Should().Be("300");
-        httpContents.FirstOrDefault(c =>
+            .ReadAsStringAsync()).Should().Be("300");
+        (await httpContents.FirstOrDefault(c =>
             c.Headers.ContentDisposition?.Name == "nativeWatermarkText")!
-            .ReadAsStringAsync().Result.Should().Be("DRAFT");
+            .ReadAsStringAsync()).Should().Be("DRAFT");
     }
 
     [Test]
@@ -230,6 +230,7 @@ public void LibreOfficeOptions_NullFields_NotIncluded()
 
     #region Integration Tests
 
+    [Category("Integration")]
     [Test]
     public async Task MergeOfficeDocs_WithLibreOfficeOptions_Succeeds()
     {