Skip to content

Commit 119f2eb

Browse files
committed
Fix: Make sure the request is disposed quickly.
Using a memory stream making this much more friendly. It sill needs to be disposed by the caller, though.
1 parent ed14597 commit 119f2eb

1 file changed

Lines changed: 13 additions & 6 deletions

File tree

lib/GotenbergSharpClient.cs

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,20 @@ public async Task FireWebhookAndForgetAsync(IApiRequest request, CancellationTok
132132
async Task<Stream> ExecuteRequestAsync(IApiRequest request, CancellationToken cancelToken)
133133
{
134134
if (request == null) throw new ArgumentNullException(nameof(request));
135-
var response = await SendRequest(request, HttpCompletionOption.ResponseHeadersRead, cancelToken);
136135

137-
#if NET5_0_OR_GREATER
138-
return await response.Content.ReadAsStreamAsync(cancelToken);
139-
#else
140-
return await response.Content.ReadAsStreamAsync().ConfigureAwait(false);
141-
#endif
136+
using var response = await this.SendRequest(request, HttpCompletionOption.ResponseHeadersRead, cancelToken);
137+
138+
var ms = new MemoryStream();
139+
140+
#if NET5_0_OR_GREATER
141+
await response.Content.CopyToAsync(ms, cancelToken);
142+
#else
143+
await response.Content.CopyToAsync(ms).ConfigureAwait(false);
144+
#endif
145+
146+
ms.Position = 0;
147+
148+
return ms;
142149
}
143150

144151
async Task<HttpResponseMessage> SendRequest(

0 commit comments

Comments
 (0)