Enforce server-side positions

Author: valkyrienyanko

Scripts/Netcode/Common/SPacketLobbyGameStart.cs

@@ -7,8 +7,11 @@ public class SPacketLobbyGameStart : APacketServer
     {
         public override void Handle()
         {
-            if (GameClient.IsHost)
+            if (GameClient.IsHost) 
+            {
                 GameServer.TimerGameLoop.Enabled = true;
+                GameServer.TimerNotifyClients.Enabled = true;
+            }
 
             SceneManager.ChangeScene("Game");
         }

Scripts/Netcode/Common/SPacketPlayerPositions.cs

@@ -0,0 +1,49 @@
+using GodotModules.Netcode.Client;
+using System;
+using System.Collections.Generic;
+using Game;
+using Godot;
+
+namespace GodotModules.Netcode 
+{
+    public class SPacketPlayerPositions : APacketServer
+    {
+        public Dictionary<uint, Vector2> PlayerPositions { get; set; }
+
+        public override void Write(PacketWriter writer)
+        {
+            writer.Write((ushort)PlayerPositions.Count);
+            foreach (var pair in PlayerPositions)
+            {
+                var id = pair.Key;
+                var pos = pair.Value;
+
+                var x = (float)Math.Round(pos.x, 1);
+                var y = (float)Math.Round(pos.y, 1);
+
+                writer.Write(pair.Key);
+                writer.Write(x);
+                writer.Write(y);
+            }
+        }
+
+        public override void Read(PacketReader reader)
+        {
+            PlayerPositions = new Dictionary<uint, Vector2>();
+            var count = reader.ReadUInt16();
+            for (int i = 0; i < count; i++)
+            {
+                var id = reader.ReadUInt32();
+                var x = reader.ReadFloat();
+                var y = reader.ReadFloat();
+
+                PlayerPositions.Add(id, new Vector2(x, y));
+            }
+        }
+
+        public override void Handle()
+        {
+            SceneGame.UpdatePlayerPositions(PlayerPositions);
+        }
+    }
+}

Scripts/Netcode/Server/GameServer.cs

@@ -13,6 +13,7 @@ public class GameServer : ENetServer
     {
         public static Dictionary<uint, DataPlayer> Players { get; set; }
         public static Timer TimerGameLoop { get; set; }
+        public static Timer TimerNotifyClients { get; set; }
         public static float Delta { get; set; }
 
         public GameServer()
@@ -21,6 +22,17 @@ public GameServer()
             TimerGameLoop = new Timer(16.67);
             TimerGameLoop.Elapsed += TimerGameLoopCallback;
             TimerGameLoop.AutoReset = true;
+
+            TimerNotifyClients = new Timer(1000);
+            TimerNotifyClients.Elapsed += TimerNotifyClientsCallback;
+            TimerNotifyClients.AutoReset = true;
+        }
+
+        public void TimerNotifyClientsCallback(System.Object source, ElapsedEventArgs args)
+        {
+            SendToAllPlayers(ServerPacketOpcode.PlayerPositions, new SPacketPlayerPositions {
+                PlayerPositions = Players.ToDictionary(x => x.Key, x => x.Value.Position)
+            });
         }
 
         public void TimerGameLoopCallback(System.Object source, ElapsedEventArgs args) 

Scripts/Scenes/Game/SceneGame.cs

@@ -3,6 +3,7 @@
 using GodotModules.ModLoader;
 using GodotModules.Netcode.Client;
 using System;
+using System.Collections.Generic;
 
 namespace Game
 {
@@ -14,12 +15,16 @@ public class SceneGame : Node
         [Export] public readonly NodePath NodePathLabelPlayerHealth;
         public Label LabelPlayerHealth;
 
+        private Dictionary<uint, OtherPlayer> Players;
+
         public override void _Ready()
         {
+            Players = new Dictionary<uint, OtherPlayer>();
             Instance = this;
             LabelPlayerHealth = GetNode<Label>(NodePathLabelPlayerHealth);
             Player = Prefabs.ClientPlayer.Instance<ClientPlayer>();
             Player.Position = Vector2.Zero;
+            Players.Add(GameClient.PeerId, Player);
             AddChild(Player);
 
             // set game definitions
@@ -38,12 +43,25 @@ public override void _Ready()
 
                     var otherPlayer = Prefabs.OtherPlayer.Instance<OtherPlayer>();
                     otherPlayer.Position = Vector2.Zero;
+                    Players.Add(pair.Key, otherPlayer);
                     AddChild(otherPlayer);
                     otherPlayer.SetUsername(pair.Value);
                 }
             }
         }
 
+        public static void UpdatePlayerPositions(Dictionary<uint, Vector2> playerPositions)
+        {
+            if (SceneManager.ActiveScene != "Game")
+                return;
+            
+            foreach (var pair in playerPositions) 
+            {
+                var player = Instance.Players[pair.Key];
+                player.Position = pair.Value;
+            }
+        }
+
         public override void _Process(float delta)
         {
             ModLoader.Call("OnGameUpdate", delta);