Check if ip is port forwarded!!

Author: valkyrienyanko

Scripts/Msc/UIPopupCreateLobby.cs

@@ -1,6 +1,7 @@
 using Godot;
 using GodotModules.Netcode;
 using GodotModules.Netcode.Client;
+using System.Threading.Tasks;
 
 namespace GodotModules
 {
@@ -84,6 +85,30 @@ private async void _on_Create_pressed()
             var name = InputTitle.Text.Trim();
             var desc = InputDescription.Text.Trim();
 
+            Hide();
+
+            NetworkManager.StartServer(port, ValidatedMaxPlayerCount);
+
+            var dummyClient = new ENetClient();
+            dummyClient.Start(WebClient.ExternalIp, port);
+            int attempts = 100;
+            while (!dummyClient.IsConnected) 
+            {
+                await Task.Delay(1);
+                attempts--;
+
+                if (attempts == 0)
+                {
+                    Logger.LogDebug($"The port '{port}' must be port forwarded first!");
+                    NetworkManager.GameServer.Stop();
+                    dummyClient.Stop();
+                    return;
+                }
+            }
+            dummyClient.Stop();
+
+            NetworkManager.StartClient(localIp, port);
+
             var info = new LobbyListing
             {
                 Name = name,
@@ -100,11 +125,6 @@ private async void _on_Create_pressed()
                 SceneGameServersScript.PostServer(info);
             SceneLobby.CurrentLobby = info;
 
-            Hide();
-
-            NetworkManager.StartServer(port, ValidatedMaxPlayerCount);
-            NetworkManager.StartClient(localIp, port);
-
             await SceneGameServersScript.ClientConnect(async () => {
                 await NetworkManager.WaitForHostToConnectToServer();
                 await NetworkManager.GameClient.Send(ClientPacketOpcode.Lobby, new CPacketLobby

Scripts/Netcode/Client/GameClient.cs

@@ -37,7 +37,8 @@ private void HandlePeerLeave(DisconnectOpcode opcode)
             Disconnected = true;
             Connected = 0;
             NetworkManager.GodotCmds.Enqueue(new GodotCmd(GodotOpcode.Disconnect, opcode));
-            CancelTokenSource.Cancel();
+            if (CancelTokenSource != null)
+                CancelTokenSource.Cancel();
         }
     }
 }

Scripts/Netcode/Server/ENetServer.cs

@@ -119,8 +119,9 @@ protected virtual void ServerCmds()
         private async Task ENetThreadWorker(ushort port, int maxClients)
         {
             Thread.CurrentThread.Name = "Server";
-            if (SceneLobby.CurrentLobby.Public && WebClient.ConnectionAlive)
-                WebClient.TimerPingMasterServer.Start();
+            if (SceneLobby.CurrentLobby != null)
+                if (SceneLobby.CurrentLobby.Public && WebClient.ConnectionAlive)
+                    WebClient.TimerPingMasterServer.Start();
 
             MaxPlayers = (ushort)maxClients;