No longer send player position from client

valkyrienyanko · valkyrienyanko · commit d024a30b9def · 2022-04-25T22:14:26.000-05:00
diff --git a/Scripts/Netcode/Common/CPacketPlayerPosition.cs b/Scripts/Netcode/Common/CPacketPlayerPosition.cs
diff --git a/Scripts/Netcode/Common/_Opcodes.cs b/Scripts/Netcode/Common/_Opcodes.cs
@@ -11,7 +11,6 @@ public enum ClientPacketOpcode
         LobbyGameStart,
         PlayerDirectionPressed,
         PlayerDirectionReleased,
-        PlayerPosition,
         ProcessDelta
     }
 
diff --git a/Scripts/Scenes/Game/ClientPlayer.cs b/Scripts/Scenes/Game/ClientPlayer.cs
@@ -11,8 +11,6 @@ namespace Game
     public class ClientPlayer : OtherPlayer
     {
         private float Speed = 250f;
-
-        private Timer TimerNotifyServerClientPosition { get; set; }
         private Timer TimerNotifyServerProcessDelta { get; set; }
         private float Delta { get; set; }
 
@@ -23,11 +21,6 @@ public override void _Ready()
 
             if (GameClient.Running)
             {
-                TimerNotifyServerClientPosition = new Timer(2000);
-                TimerNotifyServerClientPosition.Elapsed += TimerNotifyServerClientPositionCallback;
-                TimerNotifyServerClientPosition.AutoReset = true;
-                TimerNotifyServerClientPosition.Enabled = true;
-
                 if (GameClient.IsHost)
                 {
                     TimerNotifyServerProcessDelta = new Timer(3000);
@@ -38,14 +31,6 @@ public override void _Ready()
             }
         }
 
-        public async void TimerNotifyServerClientPositionCallback(System.Object source, ElapsedEventArgs args)
-        {
-            await GameClient.Send(ClientPacketOpcode.PlayerPosition, new CPacketPlayerPosition
-            {
-                Position = Position
-            });
-        }
-
         public async void TimerNotifyServerProcessDeltaCallback(System.Object source, ElapsedEventArgs args)
         {
             await GameClient.Send(ClientPacketOpcode.ProcessDelta, new CPacketProcessDelta

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ public enum ClientPacketOpcode`
`11`	`11`	`LobbyGameStart,`
`12`	`12`	`PlayerDirectionPressed,`
`13`	`13`	`PlayerDirectionReleased,`
`14`		`- PlayerPosition,`
`15`	`14`	`ProcessDelta`
`16`	`15`	`}`
`17`	`16`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@ namespace Game`
`11`	`11`	`public class ClientPlayer : OtherPlayer`
`12`	`12`	`{`
`13`	`13`	`private float Speed = 250f;`
`14`		`-`
`15`		`- private Timer TimerNotifyServerClientPosition { get; set; }`
`16`	`14`	`private Timer TimerNotifyServerProcessDelta { get; set; }`
`17`	`15`	`private float Delta { get; set; }`
`18`	`16`
`@@ -23,11 +21,6 @@ public override void _Ready()`
`23`	`21`
`24`	`22`	`if (GameClient.Running)`
`25`	`23`	`{`
`26`		`- TimerNotifyServerClientPosition = new Timer(2000);`
`27`		`- TimerNotifyServerClientPosition.Elapsed += TimerNotifyServerClientPositionCallback;`
`28`		`- TimerNotifyServerClientPosition.AutoReset = true;`
`29`		`- TimerNotifyServerClientPosition.Enabled = true;`
`30`		`-`
`31`	`24`	`if (GameClient.IsHost)`
`32`	`25`	`{`
`33`	`26`	`TimerNotifyServerProcessDelta = new Timer(3000);`
`@@ -38,14 +31,6 @@ public override void _Ready()`
`38`	`31`	`}`
`39`	`32`	`}`
`40`	`33`
`41`		`- public async void TimerNotifyServerClientPositionCallback(System.Object source, ElapsedEventArgs args)`
`42`		`- {`
`43`		`- await GameClient.Send(ClientPacketOpcode.PlayerPosition, new CPacketPlayerPosition`
`44`		`- {`
`45`		`- Position = Position`
`46`		`- });`
`47`		`- }`
`48`		`-`
`49`	`34`	`public async void TimerNotifyServerProcessDeltaCallback(System.Object source, ElapsedEventArgs args)`
`50`	`35`	`{`
`51`	`36`	`await GameClient.Send(ClientPacketOpcode.ProcessDelta, new CPacketProcessDelta`