Skip to content
This repository was archived by the owner on Sep 15, 2024. It is now read-only.

Commit 94fa2da

Browse files
2 parents 2584a0b + 6c9d9a8 commit 94fa2da

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,19 @@ Tech tree where nodes in tree are positioned automatically via script
3232
### [Helper Scripts](https://github.com/valkyrienyanko/GodotModules/blob/main/.github/UTILITY_SCRIPTS.md)
3333

3434
## Contributing
35+
There are 3 types of problems I always run into while working on this
36+
- Tasks are fired and forgotten (wanted behavior) but are not cancelled at proper times causing all sorts of problems
37+
- Duplicate player id added to lobby player dictionary
38+
- Static variables not being reset for re-use
39+
40+
Tasks are hard to manage, you cancel them with a cancellation token but it's hard to keep track if you cancel them twice or dispose them twice and get a disposed already exception.
41+
42+
With the duplicate player joining it's because their joining ID is 0 just like the host id is 0. The joining ID should be 1. Usually this is because I forgot to write or read a byte but that dosen't seem to be the case this time but I might be wrong I do not know.
43+
44+
Static variables are a mess, I wish I never used them to begin with.
45+
46+
I'm considering restarting this entire project from scratch because of how overwhelming this all is.
47+
3548
See [CONTRIBUTING.md](https://github.com/valkyrienyanko/GodotModules/blob/main/.github/CONTRIBUTING.md)
3649

3750
## Credit

0 commit comments

Comments
 (0)