From ffc2795c568e219c90c91838184cb5ae4ab3dbb9 Mon Sep 17 00:00:00 2001 From: Jassim Al-Thani Date: Sun, 6 Sep 2026 20:30:45 +0300 Subject: [PATCH] added dev container and fixed smell in serialize.ts --- .devcontainer/devcontainer.json | 5 +++++ packages/app/src/addons/serialize.ts | 15 +++++++-------- 2 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 .devcontainer/devcontainer.json diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json new file mode 100644 index 00000000..bfe5ddef --- /dev/null +++ b/.devcontainer/devcontainer.json @@ -0,0 +1,5 @@ +{ + "name": "TypeScript project", + "image": "oven/bun:1.3.14", + "postCreateCommand":"apt-get update && apt-get install -y git python3 build-essential && bun install" +} \ No newline at end of file diff --git a/packages/app/src/addons/serialize.ts b/packages/app/src/addons/serialize.ts index 51515348..dc1929b0 100644 --- a/packages/app/src/addons/serialize.ts +++ b/packages/app/src/addons/serialize.ts @@ -67,14 +67,13 @@ const isRecord = (value: unknown): value is Record => { } const isBuffer = (value: unknown): value is IBuffer => { - if (!isRecord(value)) return false - if (typeof value.length !== "number") return false - if (typeof value.cursorX !== "number") return false - if (typeof value.cursorY !== "number") return false - if (typeof value.baseY !== "number") return false - if (typeof value.viewportY !== "number") return false - if (typeof value.getLine !== "function") return false - if (typeof value.getNullCell !== "function") return false + if ((!isRecord(value)) || (typeof value.length !== "number") + || (typeof value.cursorX !== "number") + || (typeof value.cursorY !== "number") + || (typeof value.baseY !== "number") + || (typeof value.viewportY !== "number") + || (typeof value.getLine !== "function") + || (typeof value.getNullCell !== "function")) return false return true }