From af3bf747b23abf23e034e6a0395eabd871f89448 Mon Sep 17 00:00:00 2001 From: Michal Sojka Date: Sun, 14 Jun 2026 11:16:43 +0200 Subject: [PATCH] Fix build failures in update methods This fixes build errors like the following: In file included from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.3-1/src/imu_display.cpp:31: /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.3-1/src/imu_display.h:72:10: error: 'void rviz_imu_plugin::ImuDisplay::update(float, float)' marked 'override', but does not override 72 | void update(float dt, float ros_dt) override; | ^~~~~~ The update(float, float) method was replaced with update(std::chrono::duration, std::chrono::duration) in https://github.com/ros2/rviz/pull/1533. --- rviz_imu_plugin/src/imu_display.cpp | 2 +- rviz_imu_plugin/src/imu_display.h | 2 +- rviz_imu_plugin/src/mag_display.cpp | 2 +- rviz_imu_plugin/src/mag_display.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rviz_imu_plugin/src/imu_display.cpp b/rviz_imu_plugin/src/imu_display.cpp index d6936120..f71ee17b 100644 --- a/rviz_imu_plugin/src/imu_display.cpp +++ b/rviz_imu_plugin/src/imu_display.cpp @@ -113,7 +113,7 @@ void ImuDisplay::reset() acc_visual_->hide(); } -void ImuDisplay::update(float /* dt */, float /* ros_dt */) +void ImuDisplay::update(std::chrono::nanoseconds /* wall_dt */, std::chrono::nanoseconds /* ros_dt */) { updateTop(); updateBox(); diff --git a/rviz_imu_plugin/src/imu_display.h b/rviz_imu_plugin/src/imu_display.h index 7dc2598e..b7a457a7 100644 --- a/rviz_imu_plugin/src/imu_display.h +++ b/rviz_imu_plugin/src/imu_display.h @@ -69,7 +69,7 @@ class ImuDisplay void reset() override; - void update(float dt, float ros_dt) override; + void update(std::chrono::nanoseconds wall_dt, std::chrono::nanoseconds ros_dt) override; private: void createProperties(); diff --git a/rviz_imu_plugin/src/mag_display.cpp b/rviz_imu_plugin/src/mag_display.cpp index 6fb21cce..e2243c40 100644 --- a/rviz_imu_plugin/src/mag_display.cpp +++ b/rviz_imu_plugin/src/mag_display.cpp @@ -85,7 +85,7 @@ void MagDisplay::reset() mag_visual_->hide(); } -void MagDisplay::update(float /* dt */, float /* ros_dt */) +void MagDisplay::update(std::chrono::nanoseconds /* wall_dt */, std::chrono::nanoseconds /* ros_dt */) { updateMag(); } diff --git a/rviz_imu_plugin/src/mag_display.h b/rviz_imu_plugin/src/mag_display.h index 8b262b20..8b27af65 100644 --- a/rviz_imu_plugin/src/mag_display.h +++ b/rviz_imu_plugin/src/mag_display.h @@ -67,7 +67,7 @@ class MagDisplay void reset() override; - void update(float dt, float ros_dt) override; + void update(std::chrono::nanoseconds wall_dt, std::chrono::nanoseconds ros_dt) override; private: void createProperties();