Describe the bug
src/packages/buskill/__init__.py lines 1995-2002 contain a hardcoded path to the developer's personal git sandbox:
result = subprocess.run( [
'git',
'--git-dir=/home/user/sandbox/buskill-app/.git',
...
] )
When BUSKILL_VERSION['SOURCE_DATE_EPOCH'] is empty (which happens in development/testing builds), the code tries to run git against a repository at /home/user/sandbox/buskill-app/.git. On any system other than the original developer's machine, this path does not exist, causing the command to fail with fatal: not a git repository.
Steps to reproduce
- Build or run BusKill in an environment where
SOURCE_DATE_EPOCH is not set
- Trigger the upgrade check path
- The upgrade flow crashes with an unhandled exception or hangs
Expected behavior
The git path should be determined dynamically using a configurable setting or by searching for a .git directory relative to the project root, not hardcoded to a developer-specific path.
Code reference
src/packages/buskill/__init__.py:1995-2002:
if BUSKILL_VERSION['SOURCE_DATE_EPOCH'] == '':
result = subprocess.run( [
'git',
'--git-dir=/home/user/sandbox/buskill-app/.git',
...
] )
Describe the bug
src/packages/buskill/__init__.pylines 1995-2002 contain a hardcoded path to the developer's personal git sandbox:When
BUSKILL_VERSION['SOURCE_DATE_EPOCH']is empty (which happens in development/testing builds), the code tries to rungitagainst a repository at/home/user/sandbox/buskill-app/.git. On any system other than the original developer's machine, this path does not exist, causing the command to fail withfatal: not a git repository.Steps to reproduce
SOURCE_DATE_EPOCHis not setExpected behavior
The git path should be determined dynamically using a configurable setting or by searching for a
.gitdirectory relative to the project root, not hardcoded to a developer-specific path.Code reference
src/packages/buskill/__init__.py:1995-2002: