Skip to content

Commit d7c52f9

Browse files
authored
Check SBML metadata, refactor and move scripts (#152)
* add CI check for required sbml metadata * refactor scripts * moved scripts to separate dir `scripts/` * small changes to model info script * add python pip requirements file * Fix model IDs, names, and missing references (#153) * fix model ids, model names, and references (closes #147 , closes #150 ) * update overview table
1 parent f423b0d commit d7c52f9

34 files changed

Lines changed: 218 additions & 93 deletions

File tree

.github/workflows/tests.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,16 @@ jobs:
2323
run: |
2424
python -m pip install --upgrade pip
2525
pip install --upgrade setuptools wheel
26-
pip install petab
26+
pip install -r scripts/requirements.txt
2727
28-
- name: Check benchmark problems
29-
run: ./checkBenchmarkModels.py
30-
working-directory: Benchmark-Models/
28+
- name: Check with petablint
29+
run: ./check_petablint.py
30+
working-directory: scripts/
3131

3232
- name: Show overview
33-
run: ./model_info.py
34-
working-directory: Benchmark-Models/
33+
run: ./overview.py
34+
working-directory: scripts/
35+
36+
- name: Check SBML metadata
37+
run: ./check_sbml_metadata.py
38+
working-directory: scripts/

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
.~lock.*
22
*.DS_store
33
~$*
4+
__pycache__

Benchmark-Models/Alkan_SciSignal2018/model_Alkan_SciSignal2018.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model metaid="arFramework3" id="combined_model" name="NoName">
3+
<model metaid="arFramework3" id="Alkan_SciSignal2018" name="Alkan_SciSignal2018">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Alkan et al. (2018), Science Signaling 24 Jul 2018: Vol. 11, Issue 540, eaat0229</pre>

Benchmark-Models/Bachmann_MSB2011/model_Bachmann_MSB2011.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model metaid="arFramework3" id="Bachmann_MSB2011" name="jak2_stat5_feedbacks">
3+
<model metaid="arFramework3" id="Bachmann_MSB2011" name="Bachmann_MSB2011">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Bachmann et al. (2011), Mol Syst Biol. ; 7: 516. </pre>

Benchmark-Models/Beer_MolBioSystems2014/model_Beer_MolBioSystems2014.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model id="Beer_MolBioSystems2014" name="TwoStepSynthesisWithGlu">
3+
<model id="Beer_MolBioSystems2014" name="Beer_MolBioSystems2014">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Beer et al. (2014), Mol Biosyst.;10(7):1709-18</pre>

Benchmark-Models/Bertozzi_PNAS2020/model_Bertozzi_PNAS2020.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version='1.0' encoding='UTF-8'?>
22
<!-- Created by COPASI version 4.28 (Build 226) on 2020-11-30 20:43 with libSBML version 5.18.0. -->
33
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
4-
<model metaid="COPASI0" id="Bertozzi2020___SIR_model_of_scenarios_of_COVID_19_spread_in_CA" name="Bertozzi2020 - SIR model of scenarios of COVID-19 spread in CA">
4+
<model metaid="COPASI0" id="Bertozzi_PNAS2020" name="Bertozzi_PNAS2020">
55
<notes>
66
<body xmlns="http://www.w3.org/1999/xhtml">
77
<pre>Bertozzi2020 - SIR model of scenarios of COVID-19 spread in CA and NY

Benchmark-Models/Borghans_BiophysChem1997/model_Borghans_BiophysChem1997.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model id="Borghans_BiophysChem1997" name="model_Borghans_BiophysChem_1997">
3+
<model id="Borghans_BiophysChem1997" name="Borghans_BiophysChem1997">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Borghans et al. (1997), Biophysical Chemistry 66(1) 25-41</pre>

Benchmark-Models/Brannmark_JBC2010/model_Brannmark_JBC2010.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model metaid="arFramework3" id="Brannmark_JBC2010" name="model_Mif">
3+
<model metaid="arFramework3" id="Brannmark_JBC2010" name="Brannmark_JBC2010">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Brannmark et al. (2010), THE JOURNAL OF BIOLOGICAL CHEMISTRY VOL. 285, NO. 26, pp. 20171–20179, </pre>

Benchmark-Models/Chen_MSB2009/model_Chen_MSB2009.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model id="Chen_MSB2009" name="model_ChenMSB2009_sin">
3+
<model id="Chen_MSB2009" name="Chen_MSB2009">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Chen et al. (2009), Mol Syst Biol. ;5:239</pre>

Benchmark-Models/Crauste_CellSystems2017/model_Crauste_CellSystems2017.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<sbml xmlns="http://www.sbml.org/sbml/level2/version4" level="2" version="4">
3-
<model id="Crauste_CellSystems2017" name="ModelImmuneCells">
3+
<model id="Crauste_CellSystems2017" name="Crauste_CellSystems2017">
44
<notes>
55
<body xmlns="http://www.w3.org/1999/xhtml">
66
<pre>PEtab implementation of the model from Crauste et al. (2017), Cell Syst. 2017 Mar 22;4(3):306-317.e4</pre>

0 commit comments

Comments
 (0)