Skip to content

Commit 1113abb

Browse files
committed
fix merge conflict in README
2 parents 577bec1 + 31e3ac8 commit 1113abb

7 files changed

Lines changed: 94 additions & 55 deletions

File tree

.github/PULL_REQUEST_TEMPLATE/new_petab_problem.md

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
**Checklist for the submission of new PEtab problems**
2+
- [ ] The PEtab problem is based on a model that is peer-reviewed and published
3+
- [ ] The problem ID is in the format `{LAST_NAME_OF_FIRST_AUTHOR}_{ABBREVIATED_JOURNAL_NAME}{YEAR_OF_PUBLICATION}`
4+
- [ ] The problem ID is in the pull request title
5+
- [ ] There is a GitHub issue for this problem
6+
- [ ] The problem ID is in the issue title
7+
- [ ] A brief model description (one or two sentences)
8+
- [ ] A brief data description (one or two sentences)
9+
- [ ] The issue and PR are linked to each other
10+
- [ ] Differences between the implementation and the original publication are described
11+
- [ ] Experience of fitting / uncertainty analysis (e.g. optimizer used, hyperparameters, reproducibility of best fit)
12+
- [ ] Source of nominal parameters (e.g.: taken from the original publication, or from your own fitting)
13+
- [ ] The SBML file
14+
- [ ] Annotation with reference to the original publication ([example](https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/blob/3154d27edbfc4eb19b768465945bc81381a7c964/Benchmark-Models/Rahman_MBS2016/model_Rahman_MBS2016.xml#L4-L14))
15+
- [ ] The model ID and model name attributes in the SBML model file match the problem name ([example](https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/blob/3154d27edbfc4eb19b768465945bc81381a7c964/Benchmark-Models/Rahman_MBS2016/model_Rahman_MBS2016.xml#L3))
16+
- [ ] PEtab files
17+
- [ ] A "simulated data" measurement table is included, using the nominal parameters
18+
- [ ] A visualization table is included, that can be used with the simulate data to reproduce figures from the original publication
19+
- [ ] The PEtab problem is valid (check with e.g. `petablint -vy problem.yaml`)
20+
- [ ] The PEtab problem author(s) are assigned to the GitHub issue
21+
- [ ] The README has been updated with `python scripts/overview.py --update`
22+
- [ ] The new PEtab problem row in the generated table has the correct reference (and other entries)

Benchmark-Models/Froehlich_CellSystems2018/model_Froehlich_CellSystems2018.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
</dcterms:modified>
2828
<bqbiol:isDescribedBy>
2929
<rdf:Bag>
30-
<rdf:li rdf:resource="http://identifiers.org/doi/10.1126/scisignal.aat0229"/>
30+
<rdf:li rdf:resource="http://identifiers.org/doi/10.1016/j.cels.2018.10.013"/>
3131
</rdf:Bag>
3232
</bqbiol:isDescribedBy>
3333
</rdf:Description>

CONTRIBUTING.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
New submissions are very welcome! Please check our [pull request template](.github/pull_request_template.md) for guidelines.
2+
3+
Simply create a new branch and open a pull request with your files. We will then check your model and merge it into the collection.

0 commit comments

Comments
 (0)