first steps towards having AAD members of roles in Azure Analysis Services show up in Tabular Roles Report

Author: furmangg

SQL2017_VS2017_BidsHelper.csproj

@@ -66,7 +66,7 @@
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
     <OutputPath>bin\Debug\</OutputPath>
-    <DefineConstants>TRACE;DEBUG;OUTPUT_LOGGER,SQL2016,SQL2017,VS2017</DefineConstants>
+    <DefineConstants>TRACE;DEBUG;SQL2016,SQL2017,VS2017</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <CopyVsixExtensionFiles>True</CopyVsixExtensionFiles>

SQL2017_VS2017_BidsHelper.sln

@@ -1,36 +1,25 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.26430.12
+VisualStudioVersion = 15.0.27130.2036
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SQL2017_VS2017_BidsHelper", "SQL2017_VS2017_BidsHelper.csproj", "{0828F434-598D-4E5B-983A-9FAD3BFDE857}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
-		Debug|x86 = Debug|x86
 		Release|Any CPU = Release|Any CPU
-		Release|x86 = Release|x86
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
 		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Debug|x86.ActiveCfg = Debug|x86
-		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Debug|x86.Build.0 = Debug|x86
 		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Release|Any CPU.Build.0 = Release|Any CPU
-		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Release|x86.ActiveCfg = Release|x86
-		{0828F434-598D-4E5B-983A-9FAD3BFDE857}.Release|x86.Build.0 = Release|x86
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
-	GlobalSection(TeamFoundationVersionControl) = preSolution
-		SccNumberOfProjects = 2
-		SccEnterpriseProvider = {4CA58AB2-18FA-4F8D-95D4-32DDF27D184C}
-		SccTeamFoundationServer = https://tfs.codeplex.com/tfs/tfs01
-		SccLocalPath0 = .
-		SccProjectUniqueName1 = SQL2017_VS2017_BidsHelper.csproj
-		SccLocalPath1 = .
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {17981388-3AA5-4F2F-8A0E-7A94DDCE7D68}
 	EndGlobalSection
 EndGlobal

SSAS/RolesReportPlugin.cs

@@ -311,7 +311,7 @@ public override void Exec()
                         dbPerm.Process = (r.Permission == Microsoft.AnalysisServices.BackEnd.DataModelingRolePermission.Refresh || r.Permission == Microsoft.AnalysisServices.BackEnd.DataModelingRolePermission.ReadRefresh);
                         dbPerm.Read = ((r.Permission == Microsoft.AnalysisServices.BackEnd.DataModelingRolePermission.Read || r.Permission == Microsoft.AnalysisServices.BackEnd.DataModelingRolePermission.ReadRefresh) ? ReadAccess.Allowed : ReadAccess.None);
 
-                        if (r.Members.Count == 0)
+                        if (r.Members.Count == 0 && r.ExternalMembers.Count == 0)
                         {
                             RoleMemberInfo infoMember = new RoleMemberInfo();
                             infoMember.TargetServerName = _deploymentTargetServer;
@@ -333,6 +333,24 @@ public override void Exec()
 
                             listRoleMembers.AddRange(GetGroupMembers(infoMember.directoryEntry, fakeDatabase, fakeRole, 1));
                         }
+                        foreach (Microsoft.AnalysisServices.BackEnd.DataModelingRoleExternalMember rm in r.ExternalMembers)
+                        {
+                            RoleMemberInfo infoMember = new RoleMemberInfo();
+                            infoMember.TargetServerName = _deploymentTargetServer;
+                            infoMember.database = fakeDatabase;
+                            infoMember.role = fakeRole;
+                            infoMember.MemberName = rm.Name;
+
+                            //TODO: properly handle AAD members and groups
+                            //infoMember.directoryEntry = GetDirectoryEntry(rm.Name);
+                            //infoMember.MemberName = GetDomainAndUserForDirectoryEntry(infoMember.directoryEntry);
+                            //if (string.IsNullOrEmpty(infoMember.MemberName))
+                            //    infoMember.MemberName = rm.Name;
+                            listRoleMembers.Add(infoMember);
+
+                            //TODO:
+                            //listRoleMembers.AddRange(GetGroupMembers(infoMember.directoryEntry, fakeDatabase, fakeRole, 1));
+                        }
 
                         foreach (Microsoft.AnalysisServices.BackEnd.DataModelingTable table in tomTables)
                         {