Skip to content

Commit ccf854c

Browse files
committed
fixing obscure expression list expression editor bug when you don't focus the SSIS designer window first
1 parent f98c780 commit ccf854c

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

SSIS/ExpressionListControl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private void expressionGrid_CellContentClick(object sender, DataGridViewCellEven
9090
}
9191
catch (Exception ex)
9292
{
93-
MessageBox.Show("Error occured while editing the expression: " + ex.Message);
93+
MessageBox.Show("Error occured while editing the expression: " + ex.Message + "\r\n" + ex.StackTrace);
9494
}
9595
}
9696

SSIS/ExpressionListPlugin.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,12 @@ private void SetPackageAsDirty(IDTSSequence container, string expression, object
255255
PropertyDescriptorCollection properties = TypeDescriptor.GetProperties(objectChanged);
256256
System.ComponentModel.PropertyDescriptor expressionsProperty = properties.Find("Expressions", false);
257257

258+
if (designer == null)
259+
{
260+
System.Diagnostics.Debug.WriteLine("designer was null in SetPackageAsDirty");
261+
return;
262+
}
263+
258264
// Mark package object as dirty
259265
IComponentChangeService changeService = (IComponentChangeService)designer.GetService(typeof(IComponentChangeService));
260266
if (objectChanged == null)

0 commit comments

Comments
 (0)