Skip to content

Commit 9586f75

Browse files
committed
autotune: move trim airspeed setting UI to more intuitive place
1 parent 3d2af83 commit 9586f75

1 file changed

Lines changed: 13 additions & 17 deletions

File tree

autotune/autotune.py

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -100,41 +100,37 @@ def __init__(self, parent=None):
100100
left_menu = QVBoxLayout()
101101
left_menu.addWidget(self.btn_open_log)
102102

103-
pz_group = QFormLayout()
103+
id_params_group = QFormLayout()
104104
self.line_edit_zeros = QSpinBox()
105105
self.line_edit_zeros.setValue(self.sys_id_n_zeros)
106106
self.line_edit_zeros.setRange(0, 6)
107107
self.line_edit_zeros.valueChanged.connect(self.onZerosChanged)
108-
pz_group.addRow(QLabel("Zeros"), self.line_edit_zeros)
108+
id_params_group.addRow(QLabel("Zeros"), self.line_edit_zeros)
109109
self.line_edit_poles = QSpinBox()
110110
self.line_edit_poles.setValue(self.sys_id_n_poles)
111111
self.line_edit_poles.setRange(0, 6)
112112
self.line_edit_poles.valueChanged.connect(self.onPolesChanged)
113-
pz_group.addRow(QLabel("Poles"), self.line_edit_poles)
113+
id_params_group.addRow(QLabel("Poles"), self.line_edit_poles)
114114
self.line_edit_delays = QSpinBox()
115115
self.line_edit_delays.setValue(self.sys_id_delays)
116116
self.line_edit_delays.setRange(0, 1000)
117117
self.line_edit_delays.valueChanged.connect(self.onDelaysChanged)
118-
pz_group.addRow(QLabel("Delays"), self.line_edit_delays)
119-
self.btn_run_sys_id = QPushButton("Run identification")
120-
self.btn_run_sys_id.clicked.connect(self.onSysIdClicked)
121-
self.btn_run_sys_id.setEnabled(False)
122-
pz_group.addRow(self.btn_run_sys_id)
123-
left_menu.addLayout(pz_group)
124-
125-
layout_tf = self.createTfLayout()
126-
left_menu.addLayout(layout_tf)
127-
128-
129-
trim_group = QFormLayout()
118+
id_params_group.addRow(QLabel("Delays"), self.line_edit_delays)
130119
self.line_edit_trim = QDoubleSpinBox()
131120
self.trim_airspeed = 20.0
132121
self.line_edit_trim.setValue(self.trim_airspeed)
133122
self.line_edit_trim.setRange(0.0, 100.0)
134123
self.line_edit_trim.textChanged.connect(self.onTrimChanged)
135124
self.line_edit_trim.setEnabled(False)
136-
trim_group.addRow(QLabel("Trim airspeed"), self.line_edit_trim)
137-
left_menu.addLayout(trim_group)
125+
id_params_group.addRow(QLabel("Trim airspeed"), self.line_edit_trim)
126+
self.btn_run_sys_id = QPushButton("Run identification")
127+
self.btn_run_sys_id.clicked.connect(self.onSysIdClicked)
128+
self.btn_run_sys_id.setEnabled(False)
129+
id_params_group.addRow(self.btn_run_sys_id)
130+
left_menu.addLayout(id_params_group)
131+
132+
layout_tf = self.createTfLayout()
133+
left_menu.addLayout(layout_tf)
138134

139135
offset_group = QFormLayout()
140136
self.line_edit_offset = QDoubleSpinBox()

0 commit comments

Comments
 (0)