Skip to content

[GP-01] Remove model-libraries field #279

Description

@Juliette-Gerbaux

New GEMS Language Version

?

Previous Tracked Version

?

Trigger

Removal of model-libraries field in system files

Impact Analysis

The model-libraries field should not be parsed anymore. It should either be ignored or raise an error.

Validation Strategy

The model-libraries field should be removed from test studies.

Process Checklist

Step 1 — Issue Creation

  • Issue created and linked to process GP-01

Step 2 — Triage

  • Process confirmed applicable
  • Assigned to responsible contributor
  • Priority and milestone set (if applicable)

Step 3 — Impact Analysis

  • GEMS Language changelog reviewed for GemsPy-relevant changes
  • Grammar impact assessed (grammar/Expr.g4)
  • Parsing layer impact assessed (expression/, ANTLR-generated files)
  • Execution layer impact assessed (simulation/, study/)
  • Version-gated behavior required? (yes/no — document decision)
  • Results impact assessed (solver values expected to change?)
  • Breaking vs backward-compatible change identified

Step 4 — Implementation ⚠️ version-gated behavior may be required

  • Grammar updated (grammar/Expr.g4) if needed — do not edit ANTLR-generated files directly
  • ANTLR parser regenerated if grammar changed
  • Parsing and execution layers updated (expression/, simulation/, study/)
  • Version-gated behavior introduced if GemsPy must support both old and new syntax

Step 5 — Testing & Validation ⚠️ regression suite covering old and new syntax required

  • At least one reference E2E study validating new language feature added or updated
  • Regression tests covering old syntax still pass
  • If results expected to change: before/after comparison documented
  • If results must not change: confirmed via tests

Step 6 — CI Validation

  • Type checking passes (mypy)
  • Formatting passes (black, isort)
  • All tests pass in CI (pytest)

Step 7 — Review & Merge

  • PR reviewed; documentation changes included

Step 8 — Versioning

  • pyproject.toml version bumped (Major if breaking language change, Minor otherwise)

Step 9 — Supporting Files

  • AGENTS.md reviewed for impact and updated if needed

Step 10 — Release

  • If a release is needed: follow the release process in the Developer Guidelines

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions