Description
When doing git push, there is a false positive CRITICAL error when a Drupal core module (such as page_cache) is uninstalled. The script incorrectly assumes the module's code has been deleted because it does not scan the Drupal core directories.
✗ CRITICAL: Module 'page_cache' is being uninstalled AND its code/package removed in the same change — uninstall first (deploy), then remove code in a later change
Steps to Reproduce
- Uninstall a core module (e.g.
page_cache) so it is removed from core.extension.yml.
- Commit the
core.extension.yml file and do a git push
- The script fails with:
CRITICAL: Module 'page_cache' is being uninstalled AND its code/package removed in the same change
Possible solution
Update the check-drupal-safe-uninstall.sh script to include core module paths.
Description
When doing
git push, there is a false positiveCRITICALerror when a Drupal core module (such aspage_cache) is uninstalled. The script incorrectly assumes the module's code has been deleted because it does not scan the Drupal core directories.Steps to Reproduce
page_cache) so it is removed fromcore.extension.yml.core.extension.ymlfile and do agit pushCRITICAL: Module 'page_cache' is being uninstalled AND its code/package removed in the same changePossible solution
Update the
check-drupal-safe-uninstall.shscript to include core module paths.