From fdf95758a3827d40ae21c75b46debaeeadeb4c3b Mon Sep 17 00:00:00 2001 From: "sonarqube-agent[bot]" <210722872+sonarqube-agent[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 13:02:47 +0000 Subject: [PATCH] fix: Address 4 SonarQube issues Fixed issues: - AYfoIGOgqfEBxbAAXPMq for csharpsquid:S1118 rule - AYfoIGSpqfEBxbAAXPMt for csharpsquid:S2486 rule - AYfoIGSpqfEBxbAAXPMu for csharpsquid:S108 rule - AYfoIGSZqfEBxbAAXPMs for csharpsquid:S125 rule Generated by SonarQube Agent (task: 920d3784-6d49-4ab8-bd2e-b182b877bcda) --- src/Cake.Parallel/ParallelCakeEngine.cs | 5 ++++- src/Cake.Parallel/ParallelGraphBuilder.cs | 2 +- src/Cake.Parallel/ParallelGraphExtensions.cs | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Cake.Parallel/ParallelCakeEngine.cs b/src/Cake.Parallel/ParallelCakeEngine.cs index 9197367..1020c41 100644 --- a/src/Cake.Parallel/ParallelCakeEngine.cs +++ b/src/Cake.Parallel/ParallelCakeEngine.cs @@ -296,7 +296,10 @@ private void ReportErrors(IExecutionStrategy strategy, Action errorRe { strategy.ReportErrors(errorReporter, taskException); } - catch { } + catch + { + // Intentionally suppressed: if error reporting itself fails, there is nothing more we can do. + } } private void HandleErrors(IExecutionStrategy strategy, Action errorHandler, Exception exception) diff --git a/src/Cake.Parallel/ParallelGraphBuilder.cs b/src/Cake.Parallel/ParallelGraphBuilder.cs index dd9e4ee..3c87a0a 100644 --- a/src/Cake.Parallel/ParallelGraphBuilder.cs +++ b/src/Cake.Parallel/ParallelGraphBuilder.cs @@ -8,7 +8,7 @@ namespace Cake.Parallel.Module { - public class ParallelGraphBuilder + public static class ParallelGraphBuilder { public static CakeGraph Build(List tasks) { diff --git a/src/Cake.Parallel/ParallelGraphExtensions.cs b/src/Cake.Parallel/ParallelGraphExtensions.cs index 23ced0e..62a9964 100644 --- a/src/Cake.Parallel/ParallelGraphExtensions.cs +++ b/src/Cake.Parallel/ParallelGraphExtensions.cs @@ -51,7 +51,7 @@ private static async Task Traverse( } // The below line does work correctly, but does not bubble up the TaskCanceledException - // await executeTask(nodeName, cancellationTokenSource).ConfigureAwait(false); + await Task.Run(() => executeTask(nodeName, cancellationTokenSource), token).ConfigureAwait(false); }