fix(ios): resolve prebuild failure with Swift AppDelegate (#93)#94
Merged
giolaq merged 1 commit intoMay 26, 2026
Merged
Conversation
…ev#93) Replace @bam.tech/react-native-keyevent-expo-config-plugin with a local Android-only plugin since the upstream plugin expects an Objective-C AppDelegate but Expo 54 generates Swift. The iOS side never needed it as TVEventHandler handles key events natively on tvOS. Also fix related build issues: - Add withTvosDeploymentTarget plugin (Expo modules require tvOS 15.1) - Rewrite withKotlinJvmTarget to define ext.kotlinVersion in build.gradle - Update kotlinVersion to 2.0.21, compileSdkVersion to 36, minSdkVersion to 24 - Move newArchEnabled to top-level app config (fixes deprecation warning)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
yarn dev:iosfails during prebuild because@bam.tech/react-native-keyevent-expo-config-pluginexpects an Objective-C@implementation AppDelegatebut Expo 54 + RN 0.81 generates a Swift AppDelegate.
plugins/withKeyEvent.jsthat only applies Android-side modifications (iOS usesTVEventHandlernatively andnever needed
react-native-keyevent)plugins/withTvosDeploymentTarget.jsto set tvOS deployment target to 15.1 (required by Expo modules)plugins/withKotlinJvmTarget.jsto properly defineext.kotlinVersionin the rootbuild.gradle(the previous version targeted a non-existentreact-settings-plugin/build.gradle.kts)kotlinVersionto 2.0.21,compileSdkVersionto 36,minSdkVersionto 24 for Expo 54 compatibilitynewArchEnabledto top-level app config to fix deprecation warning