refactor(sync): require explicit home directory

Author: kushagrchitkar

docs/intentional-architecture-rewrite-2026-06-27/status.md

@@ -5,7 +5,7 @@ Branch: `codex/intentional-architecture-rewrite`
 
 ## Current State
 
-The branch has 195 committed rewrite commits past `dev`. The worklog records 149 production slices so far.
+The branch has 196 committed rewrite commits past `dev`. The worklog records 150 production slices so far.
 
 The diff is broad: 350 files changed, with about 20.4k insertions and 10.6k deletions.
 
@@ -36,9 +36,9 @@ This is no longer a small cleanup branch. It is a real ownership rewrite.
 
 ## Latest Checkpoint
 
-The latest slice made setup instruction home-directory ownership explicit. The setup command already receives `homeDir` from CLI edges; the guide-install step now passes it into setup services, and `src/services/setup/instructions.ts` no longer defaults to `homedir()`.
+The latest slice made sync home-directory ownership explicit. The sync CLI edge now passes `homeDir`; `src/cli/commands/sync.ts` and `src/services/sync/types.ts` require it, and `src/services/sync/sync.ts` no longer defaults to `homedir()`.
 
-Verification passed: `npm run lint`, focused setup/uninstall/CLI/boundary tests, full `npm test` with 655 tests, `npm run build`, `git diff --check`, `node dist/codealmanac.js --version`, and `node dist/codealmanac.js automation status`.
+Verification passed: `npm run lint`, focused sync/CLI/boundary tests, full `npm test` with 655 tests, `npm run build`, `git diff --check`, `node dist/codealmanac.js --version`, `node dist/codealmanac.js sync status --json`, and `node dist/codealmanac.js automation status`.
 
 ## Immediate Next Work
 

docs/intentional-architecture-rewrite-2026-06-27/worklog.md

@@ -995,3 +995,9 @@ One-hundred-forty-ninth production slice:
 - Made setup instruction installation require an explicit `homeDir` instead of defaulting to `homedir()` inside `src/services/setup/instructions.ts`.
 - Threaded the existing setup command `homeDir` through the guide-install step into the setup service.
 - Added boundary guards so setup instruction services cannot reintroduce ambient home-directory ownership.
+
+One-hundred-fiftieth production slice:
+
+- Made sync workflow options require an explicit `homeDir` instead of defaulting to `homedir()` inside `src/services/sync/sync.ts`.
+- Threaded `homeDir` from `src/edges/cli/register-sync-commands.ts` through `src/cli/commands/sync.ts` into the sync service.
+- Added boundary guards so sync services cannot reintroduce ambient home-directory ownership.

src/cli/commands/sync.ts

@@ -12,7 +12,7 @@ export interface SyncCommandOptions {
   using?: string;
   json?: boolean;
   now?: Date;
-  homeDir?: string;
+  homeDir: string;
   configPath?: string;
   startBackground?: SyncWorkflowOptions["startBackground"];
   workerProgram: SyncWorkflowOptions["workerProgram"];

src/edges/cli/register-sync-commands.ts

@@ -1,4 +1,5 @@
 import { Command } from "commander";
+import { homedir } from "node:os";
 
 import { currentCliNodeProgram } from "./current-cli.js";
 import { emit } from "./helpers.js";
@@ -24,6 +25,7 @@ export function registerSyncCommands(program: Command): void {
         quiet: opts.quiet,
         using: opts.using,
         json: opts.json,
+        homeDir: homedir(),
         workerProgram: currentCliNodeProgram(),
         workerEnvironment: process.env,
         pid: process.pid,
@@ -54,6 +56,7 @@ export function registerSyncCommands(program: Command): void {
         from: opts.from ?? parentOpts.from,
         quiet: opts.quiet ?? parentOpts.quiet,
         json: opts.json ?? parentOpts.json,
+        homeDir: homedir(),
         workerProgram: currentCliNodeProgram(),
         workerEnvironment: process.env,
         pid: process.pid,

src/services/sync/sync.ts

@@ -1,5 +1,3 @@
-import { homedir } from "node:os";
-
 import * as operations from "../../operations/index.js";
 import * as sync from "../../sync/index.js";
 import { readConfig } from "../../config/index.js";
@@ -31,7 +29,7 @@ export async function runSyncWorkflow(
       await sync.sweep({
         candidates: await sync.discoverCandidates({
           apps: sources.value,
-          home: options.homeDir ?? homedir(),
+          home: options.homeDir,
         }),
         syncSince: await readSyncSince(options.configPath),
         quietMs: quiet.ms,

src/services/sync/types.ts

@@ -9,7 +9,7 @@ export interface SyncWorkflowOptions {
   quiet?: string;
   using?: string;
   now?: Date;
-  homeDir?: string;
+  homeDir: string;
   configPath?: string;
   startBackground?: StartBackgroundJob;
   workerProgram: JobWorkerProgram;

test/architecture-boundaries.test.ts

@@ -591,6 +591,7 @@ describe("architecture boundaries", () => {
     expect(existsSync(join(ROOT, "src/cli/commands/sync-render.ts"))).toBe(true);
     expect(syncCommand).not.toContain("import type { CommandResult }");
     expect(syncCommand).not.toContain("extends SyncWorkflowOptions");
+    expect(syncCommand).toContain("homeDir: string");
     expect(syncCommand).toContain("toSyncWorkflowOptions");
     expect(syncCommand).not.toContain("renderOutcome");
     expect(syncCommand).not.toContain("renderError");
@@ -1254,7 +1255,10 @@ describe("architecture boundaries", () => {
     expect(syncServiceIndex).not.toContain("../../sync");
     expect(syncService).not.toContain("interface SyncWorkflowOptions");
     expect(syncService).not.toContain("interface SyncWorkflowSummary");
+    expect(syncService).not.toContain("homedir");
     expect(syncServiceTypes).toContain("interface SyncWorkflowOptions");
+    expect(syncServiceTypes).toContain("homeDir: string");
+    expect(syncServiceTypes).not.toContain("homeDir?: string");
     expect(syncServiceTypes).toContain("interface SyncWorkflowSummary");
     expect(syncService).not.toContain("export type SyncWorkflowSummary = sync.SyncSummary");
     expect(syncService).not.toContain(