Merge branch 'fixes' of https://github.com/AllanKoder/ComputerScienceResources.com into fixes

Author: AllanKoder

app/Http/Controllers/ComputerScienceResourceController.php

@@ -2,7 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use App\Events\TagFrequencyChanged;
 use App\Http\Requests\StoreResourceRequest;
 use App\Models\ComputerScienceResource;
 use App\Models\NewsPost;

app/Http/Controllers/ResourceEditsController.php

@@ -2,7 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use App\Events\TagFrequencyChanged;
 use App\Http\Requests\StoreResourceEdit;
 use App\Models\ComputerScienceResource;
 use App\Models\ResourceEdits;

app/Http/Controllers/TagFrequencyController.php

@@ -12,8 +12,7 @@ public function search(string $type, string $query = '')
             return response()->json(['message' => 'Query too long'], 422);
         }
 
-        if (!in_array($type, ['topics_tags', 'programming_languages_tags', 'general_tags']))
-        {
+        if (! in_array($type, ['topics_tags', 'programming_languages_tags', 'general_tags'])) {
             return response()->json(['message' => 'Not a valid type'], 422);
         }
 

app/Listeners/ModifyTagFrequency.php

@@ -18,8 +18,8 @@ public function __construct()
     /**
      * Update tag frequencies based on two arrays of tags.
      *
-     * @param array $oldTags Array of old tags (e.g. ['php', 'laravel', ...])
-     * @param array $newTags Array of new tags (e.g. ['php', 'vue', ...])
+     * @param  array  $oldTags  Array of old tags (e.g. ['php', 'laravel', ...])
+     * @param  array  $newTags  Array of new tags (e.g. ['php', 'vue', ...])
      */
     public function handle(TagFrequencyChanged $event): void
     {

app/Models/ComputerScienceResource.php

@@ -68,7 +68,7 @@ public function user(): BelongsTo
     protected function imageUrl(): Attribute
     {
         return Attribute::make(
-            get: fn() => $this->image_path ? Storage::disk('public')->url($this->image_path) : null,
+            get: fn () => $this->image_path ? Storage::disk('public')->url($this->image_path) : null,
         );
     }
 
@@ -99,8 +99,8 @@ public function edits(): HasMany
     protected function platforms(): Attribute
     {
         return Attribute::make(
-            get: fn($value) => explode(',', $value),
-            set: fn($value) => implode(',', $value)
+            get: fn ($value) => explode(',', $value),
+            set: fn ($value) => implode(',', $value)
         );
     }
 
@@ -110,7 +110,7 @@ protected function platforms(): Attribute
     protected function topicTags(): Attribute
     {
         return Attribute::make(
-            get: fn() => $this->tagsWithType('topics_tags')->pluck('name')->toArray(),
+            get: fn () => $this->tagsWithType('topics_tags')->pluck('name')->toArray(),
             set: function (array $value) {
                 $old_value = $this->topic_tags;
                 $this->syncTagsWithType($value, 'topics_tags');
@@ -127,7 +127,7 @@ protected function topicTags(): Attribute
     protected function programmingLanguageTags(): Attribute
     {
         return Attribute::make(
-            get: fn() => $this->tagsWithType('programming_languages_tags')->pluck('name')->toArray(),
+            get: fn () => $this->tagsWithType('programming_languages_tags')->pluck('name')->toArray(),
             set: function (array $value) {
                 $old_value = $this->programming_language_tags;
                 $this->syncTagsWithType($value, 'programming_languages_tags');
@@ -144,7 +144,7 @@ protected function programmingLanguageTags(): Attribute
     protected function generalTags(): Attribute
     {
         return Attribute::make(
-            get: fn() => $this->tagsWithType('general_tags')->pluck('name')->toArray(),
+            get: fn () => $this->tagsWithType('general_tags')->pluck('name')->toArray(),
             set: function (array $value) {
                 $old_value = $this->general_tags;
                 $this->syncTagsWithType($value, 'general_tags');

database/factories/ComputerScienceResourceFactory.php

@@ -2,7 +2,6 @@
 
 namespace Database\Factories;
 
-use App\Events\TagFrequencyChanged;
 use App\Models\ComputerScienceResource;
 use App\Models\User;
 use Illuminate\Database\Eloquent\Factories\Factory;
@@ -60,7 +59,7 @@ public function configure(): Factory
             do {
                 $topicTags = $this->topicTags ?? fake()->randomElements($fakerTags, fake()->numberBetween(3, count($fakerTags)));
                 $topicTags = array_map([$this, 'sanitizeTag'], $topicTags);
-            } while (sizeof($topicTags) < 2);
+            } while (count($topicTags) < 2);
 
             $programmingLanguageTags = $this->programmingLanguageTags ?? fake()->randomElements($fakerTags);
             $programmingLanguageTags = array_map([$this, 'sanitizeTag'], $programmingLanguageTags);

tests/Feature/TagSearchTest.php

@@ -78,10 +78,10 @@ public function test_creating_resource_updates_tag_frequency()
         $response->assertStatus(200);
 
         // Check that TagFrequency reflects counts
-        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'python', 'type'=>'topics_tags', 'count' => 1]);
-        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'python', 'type'=>'programming_languages_tags', 'count' => 1]);
-        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'algorithms', 'type'=>'topics_tags', 'count' => 1]);
-        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'beginner', 'type'=>'general_tags', 'count' => 1]);
+        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'python', 'type' => 'topics_tags', 'count' => 1]);
+        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'python', 'type' => 'programming_languages_tags', 'count' => 1]);
+        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'algorithms', 'type' => 'topics_tags', 'count' => 1]);
+        $this->assertDatabaseHas('tag_frequencies', ['tag' => 'beginner', 'type' => 'general_tags', 'count' => 1]);
     }
 
     public function test_dispatching_tag_frequency_change_removes_unused_tags()
@@ -101,15 +101,15 @@ public function test_dispatching_tag_frequency_change_removes_unused_tags()
         TagFrequencyChanged::dispatch('general_tags', [
             'python',
             'java',
-            'ruby'
+            'ruby',
         ], []); // no tags used now
 
         // Step 3: Ensure all tag frequencies are removed
         $this->assertDatabaseMissing('tag_frequencies', ['tag' => 'python']);
         $this->assertDatabaseMissing('tag_frequencies', ['tag' => 'java']);
         $this->assertDatabaseMissing('tag_frequencies', ['tag' => 'ruby']);
 
-        $response = $this->getJson(route('tags.search', ['type'=> 'general_tags', 'query' => 'py']));
+        $response = $this->getJson(route('tags.search', ['type' => 'general_tags', 'query' => 'py']));
         $response->assertStatus(200);
         $this->assertEmpty($response->json('tags'));
     }