Add line break and indentation to FROM clause formatting (#244)

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: git-hulk <4987594+git-hulk@users.noreply.github.com>

Author: Copilot

parser/format.go

@@ -71,7 +71,6 @@ func (f *Formatter) WriteExpr(expr Expr) {
 	expr.FormatSQL(f)
 }
 
-
 func (f *Formatter) NewLine() {
 	if f.mode != FormatModeBeautify {
 		return
@@ -1436,8 +1435,11 @@ func (f *FormatClause) FormatSQL(formatter *Formatter) {
 }
 
 func (f *FromClause) FormatSQL(formatter *Formatter) {
-	formatter.WriteString("FROM ")
+	formatter.WriteString("FROM")
+	formatter.Indent()
+	formatter.Break()
 	formatter.WriteExpr(f.Expr)
+	formatter.Dedent()
 }
 
 func (f *FunctionExpr) FormatSQL(formatter *Formatter) {

parser/testdata/ddl/format/beautify/bug_001.sql

@@ -30,6 +30,7 @@ CREATE MATERIALIZED VIEW IF NOT EXISTS db.table ON CLUSTER 'default_cluster' TO
   visitParamExtractString(properties, 'd') AS d,
   visitParamExtractInt(properties, 'e') AS e,
   visitParamExtractInt(properties, 'f') AS f
-FROM db.table
+FROM
+  db.table
 WHERE
   db.table.event = 'hello';

parser/testdata/ddl/format/beautify/create_live_view_basic.sql

@@ -9,4 +9,5 @@ CREATE LIVE VIEW my_live_view WITH TIMEOUT 10 TO my_destination (
   id String
 ) AS SELECT
   id
-FROM my_table;
+FROM
+  my_table;

parser/testdata/ddl/format/beautify/create_materialized_view_basic.sql

@@ -37,6 +37,7 @@ CREATE MATERIALIZED VIEW infra_bm.view_name ON CLUSTER 'default_cluster' TO infr
   visitParamExtractString(properties, 'f4') AS f4,
   visitParamExtractString(properties, 'f5') AS f5,
   visitParamExtractInt(properties, 'f6') AS f6
-FROM infra_bm.table_name1
+FROM
+  infra_bm.table_name1
 WHERE
   infra_bm.table_name1.event = 'test-event' COMMENT 'Comment for table';

parser/testdata/ddl/format/beautify/create_materialized_view_with_empty_table_schema.sql

@@ -25,16 +25,18 @@ PARTITION BY toYYYYMM(f0) POPULATE AS SELECT
   f1,
   f2,
   coalesce(f0, f1) AS f333
-FROM (SELECT
-  f0,
-  f1,
-  f2,
-  ROW_NUMBER() OVER (PARTITION BY f0 ORDER BY
-    coalesce(f1, f2)) AS rn
-FROM test.t
-WHERE
-  f3 IN ('foo', 'bar', 'test')
-AND
-  env = 'test') AS tmp
+FROM
+  (SELECT
+    f0,
+    f1,
+    f2,
+    ROW_NUMBER() OVER (PARTITION BY f0 ORDER BY
+      coalesce(f1, f2)) AS rn
+  FROM
+    test.t
+  WHERE
+    f3 IN ('foo', 'bar', 'test')
+  AND
+    env = 'test') AS tmp
 WHERE
   rn = 1;

parser/testdata/ddl/format/beautify/create_materialized_view_with_gcs.sql

@@ -6,4 +6,5 @@ CREATE MATERIALIZED VIEW database_name.view_name
 -- Beautify SQL:
 CREATE MATERIALIZED VIEW database_name.view_name REFRESH EVERY 5 MINUTE TO database_name.table_name AS SELECT
   *
-FROM gcs(gcs_creds, url='https://storage.googleapis.com/some-bucket/some-path/');
+FROM
+  gcs(gcs_creds, url='https://storage.googleapis.com/some-bucket/some-path/');

parser/testdata/ddl/format/beautify/create_mv_with_not_op.sql

@@ -34,7 +34,8 @@ CREATE MATERIALIZED VIEW infra_bm.view_name ON CLUSTER 'default_cluster' TO infr
   visitParamExtractString(properties, 'f4') AS f4,
   visitParamExtractString(properties, 'f5') AS f5,
   visitParamExtractInt(properties, 'f6') AS f6
-FROM infra_bm.table_name1
+FROM
+  infra_bm.table_name1
 WHERE
   infra_bm.table_name1.event = 'test-event'
 AND

parser/testdata/ddl/format/beautify/create_mv_with_order_by.sql

@@ -19,9 +19,11 @@ ORDER BY
   (id)
 PRIMARY KEY (id) AS SELECT
   *
-FROM test_table;
+FROM
+  test_table;
 CREATE MATERIALIZED VIEW IF NOT EXISTS test_mv
 ENGINE = ReplacingMergeTree()
 PRIMARY KEY (id) AS SELECT
   *
-FROM test_table;
+FROM
+  test_table;

parser/testdata/ddl/format/beautify/create_or_replace.sql

@@ -45,5 +45,6 @@ CREATE OR REPLACE VIEW IF NOT EXISTS my_view (
 ) AS SELECT
   id,
   name
-FROM my_table;
+FROM
+  my_table;
 CREATE OR REPLACE FUNCTION IF NOT EXISTS my_function AS (x, y) -> x + y;

parser/testdata/ddl/format/beautify/create_view_basic.sql

@@ -14,4 +14,5 @@ CREATE VIEW IF NOT EXISTS my_view (
 ) AS SELECT
   id,
   name
-FROM my_table;
+FROM
+  my_table;