Skip to content

Commit 3ba1616

Browse files
committed
Fixing
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
1 parent 92cf14f commit 3ba1616

3 files changed

Lines changed: 6 additions & 34 deletions

File tree

parser/parser_column.go

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -518,36 +518,7 @@ func (p *Parser) parseColumnExprListWithTerm(term TokenKind, pos Pos) (*ColumnEx
518518
if term != "" && p.matchTokenKind(term) {
519519
break
520520
}
521-
522-
// Check if this is a named parameter (identifier followed by =)
523-
// We need to peek ahead to see if there's an identifier followed by =
524-
var columnExpr Expr
525-
var err error
526-
527-
// Try to detect named parameter pattern: identifier = value
528-
isNamedParam := false
529-
firstToken, peekErr := p.lexer.peekToken()
530-
if peekErr == nil && firstToken != nil && (firstToken.Kind == TokenKindIdent || firstToken.Kind == TokenKindKeyword) {
531-
// Peek two tokens ahead to check for =
532-
// Save state, consume first token, peek second, restore
533-
savedState := p.lexer.saveState()
534-
if err := p.lexer.consumeToken(); err == nil {
535-
secondToken, peekErr2 := p.lexer.peekToken()
536-
if peekErr2 == nil && secondToken != nil && secondToken.Kind == TokenKindSingleEQ {
537-
isNamedParam = true
538-
}
539-
}
540-
p.lexer.restoreState(savedState)
541-
}
542-
543-
if isNamedParam {
544-
// Parse as named parameter
545-
columnExpr, err = p.parseNamedParameter(p.Pos())
546-
} else {
547-
// Parse as regular column expression
548-
columnExpr, err = p.parseColumnsExpr(p.Pos())
549-
}
550-
521+
columnExpr, err := p.parseColumnsExpr(p.Pos())
551522
if err != nil {
552523
return nil, err
553524
}

parser/parser_table.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -652,19 +652,19 @@ func (p *Parser) parseTableArgList(pos Pos) (*TableArgListExpr, error) {
652652
// Check if this is a named parameter (identifier followed by =)
653653
var arg Expr
654654
var err error
655-
655+
656656
// Try to detect named parameter pattern: last token is identifier, next token is =
657657
isNamedParam := false
658658
lastKind := p.lastTokenKind()
659659
if lastKind == TokenKindIdent || lastKind == TokenKindKeyword {
660660
// Last token is an identifier, peek at the next token
661661
nextToken, peekErr := p.lexer.peekToken()
662-
662+
663663
if peekErr == nil && nextToken != nil && nextToken.Kind == TokenKindSingleEQ {
664664
isNamedParam = true
665665
}
666666
}
667-
667+
668668
if isNamedParam {
669669
// Parse as named parameter - the identifier is already the last token
670670
// We need to get it, consume the =, and parse the value
@@ -694,7 +694,7 @@ func (p *Parser) parseTableArgList(pos Pos) (*TableArgListExpr, error) {
694694
// Parse as regular table arg expression
695695
arg, err = p.parseTableArgExpr(p.Pos())
696696
}
697-
697+
698698
if err != nil {
699699
return nil, err
700700
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
SELECT * FROM gcs(gcs_creds,url='https://storage.googleapis.com/some-bucket/some-path/');

0 commit comments

Comments
 (0)