Improve the ALTER TABLE format

Author: git-hulk

parser/format.go

@@ -312,7 +312,9 @@ func (a *AlterTableClearProjection) FormatSQL(formatter *Formatter) {
 }
 
 func (a *AlterTableDelete) FormatSQL(formatter *Formatter) {
-	formatter.WriteString("DELETE WHERE ")
+	formatter.WriteString("DELETE")
+	formatter.Break()
+	formatter.WriteString("WHERE ")
 	formatter.WriteExpr(a.WhereClause)
 }
 
@@ -409,18 +411,26 @@ func (a *AlterTableModifyColumn) FormatSQL(formatter *Formatter) {
 }
 
 func (a *AlterTableModifyQuery) FormatSQL(formatter *Formatter) {
-	formatter.WriteString("MODIFY QUERY ")
+	formatter.WriteString("MODIFY QUERY")
+	formatter.Indent()
+	formatter.Break()
 	formatter.WriteExpr(a.SelectExpr)
+	formatter.Dedent()
 }
 
 func (a *AlterTableModifySetting) FormatSQL(formatter *Formatter) {
-	formatter.WriteString("MODIFY SETTING ")
+	formatter.WriteString("MODIFY SETTING")
+	formatter.Indent()
 	for i, setting := range a.Settings {
-		if i > 0 {
-			formatter.WriteString(", ")
+		if i == 0 {
+			formatter.Break()
+		} else {
+			formatter.WriteByte(',')
+			formatter.Break()
 		}
 		formatter.WriteExpr(setting)
 	}
+	formatter.Dedent()
 }
 
 func (a *AlterTableModifyTTL) FormatSQL(formatter *Formatter) {
@@ -450,28 +460,40 @@ func (a *AlterTableReplacePartition) FormatSQL(formatter *Formatter) {
 }
 
 func (a *AlterTableResetSetting) FormatSQL(formatter *Formatter) {
-	formatter.WriteString("RESET SETTING ")
+	formatter.WriteString("RESET SETTING")
+	formatter.Indent()
 	for i, setting := range a.Settings {
-		if i > 0 {
-			formatter.WriteString(", ")
+		if i == 0 {
+			formatter.Break()
+		} else {
+			formatter.WriteByte(',')
+			formatter.Break()
 		}
 		formatter.WriteExpr(setting)
 	}
+	formatter.Dedent()
 }
 
 func (a *AlterTableUpdate) FormatSQL(formatter *Formatter) {
-	formatter.WriteString("UPDATE ")
+	formatter.WriteString("UPDATE")
+	formatter.Indent()
 	for i, assignment := range a.Assignments {
-		if i > 0 {
-			formatter.WriteString(", ")
+		if i == 0 {
+			formatter.Break()
+		} else {
+			formatter.WriteByte(',')
+			formatter.Break()
 		}
 		formatter.WriteExpr(assignment)
 	}
+	formatter.Dedent()
 	if a.InPartition != nil {
-		formatter.WriteString(" IN ")
+		formatter.Break()
+		formatter.WriteString("IN ")
 		formatter.WriteExpr(a.InPartition)
 	}
-	formatter.WriteString(" WHERE ")
+	formatter.Break()
+	formatter.WriteString("WHERE ")
 	formatter.WriteExpr(a.WhereClause)
 }
 

parser/testdata/ddl/format/beautify/alter_table_delete.sql

@@ -4,4 +4,5 @@ ALTER TABLE test.events DELETE WHERE created_at < '2023-01-01';
 
 -- Beautify SQL:
 ALTER TABLE test.events
-DELETE WHERE created_at < '2023-01-01';
+DELETE
+WHERE created_at < '2023-01-01';

parser/testdata/ddl/format/beautify/alter_table_delete_with_cluster.sql

@@ -5,6 +5,7 @@ ALTER TABLE test.events ON CLUSTER 'default_cluster' DELETE WHERE id = 123 AND s
 -- Beautify SQL:
 ALTER TABLE test.events
 ON CLUSTER 'default_cluster'
-DELETE WHERE id = 123
+DELETE
+WHERE id = 123
 AND
   status = 'deleted';

parser/testdata/ddl/format/beautify/alter_table_modify_setting.sql

@@ -3,4 +3,6 @@ ALTER TABLE example_table MODIFY SETTING max_part_loading_threads=8, max_parts_i
 
 -- Beautify SQL:
 ALTER TABLE example_table
-MODIFY SETTING max_part_loading_threads=8, max_parts_in_total=50000;
+MODIFY SETTING
+  max_part_loading_threads=8,
+  max_parts_in_total=50000;

parser/testdata/ddl/format/beautify/alter_table_reset_multiple_settings.sql

@@ -3,4 +3,7 @@ ALTER TABLE example_table RESET SETTING max_part_loading_threads, max_parts_in_t
 
 -- Beautify SQL:
 ALTER TABLE example_table
-RESET SETTING max_part_loading_threads, max_parts_in_total, another_setting;
+RESET SETTING
+  max_part_loading_threads,
+  max_parts_in_total,
+  another_setting;

parser/testdata/ddl/format/beautify/alter_table_reset_setting.sql

@@ -3,4 +3,5 @@ ALTER TABLE example_table RESET SETTING max_part_loading_threads;
 
 -- Beautify SQL:
 ALTER TABLE example_table
-RESET SETTING max_part_loading_threads;
+RESET SETTING
+  max_part_loading_threads;

parser/testdata/ddl/format/beautify/alter_table_update.sql

@@ -4,4 +4,7 @@ ALTER TABLE test.users UPDATE status = 'active', updated_at = now() WHERE status
 
 -- Beautify SQL:
 ALTER TABLE test.users
-UPDATE status = 'active', updated_at = now() WHERE status = 'pending';
+UPDATE
+  status = 'active',
+  updated_at = now()
+WHERE status = 'pending';

parser/testdata/ddl/format/beautify/alter_table_update_in_partition.sql

@@ -4,4 +4,7 @@ ALTER TABLE test.users UPDATE status = 'inactive' IN PARTITION '2024-01-01' WHER
 
 -- Beautify SQL:
 ALTER TABLE test.users
-UPDATE status = 'inactive' IN PARTITION '2024-01-01' WHERE status = 'active';
+UPDATE
+  status = 'inactive'
+IN PARTITION '2024-01-01'
+WHERE status = 'active';

parser/testdata/ddl/format/beautify/alter_table_update_with_cluster.sql

@@ -5,4 +5,6 @@ ALTER TABLE db.table ON CLUSTER cluster1 UPDATE column1 = column1 + 1 WHERE id >
 -- Beautify SQL:
 ALTER TABLE db.table
 ON CLUSTER cluster1
-UPDATE column1 = column1 + 1 WHERE id > 100;
+UPDATE
+  column1 = column1 + 1
+WHERE id > 100;

parser/testdata/dml/format/beautify/alter_table_modify_query.sql

@@ -4,10 +4,11 @@ ALTER TABLE test.some_mv ON CLUSTER cluster MODIFY QUERY SELECT field1, field2 F
 -- Beautify SQL:
 ALTER TABLE test.some_mv
 ON CLUSTER cluster
-MODIFY QUERY SELECT
-  field1,
-  field2
-FROM
-  test.some_table
-WHERE
-  count >= 3;
+MODIFY QUERY
+  SELECT
+    field1,
+    field2
+  FROM
+    test.some_table
+  WHERE
+    count >= 3;