From 4b429e004657eb32839fa51584743161b73f5181 Mon Sep 17 00:00:00 2001
From: Bob <bob@superuserlabs.org>
Date: Thu, 20 Aug 2026 10:31:54 +0000
Subject: [PATCH] ci(release): export VERSION_NO_V so the aw-server-rust
 version check sees the tag

The 'Determine and output version' step computed VERSION_NO_V but only
exported VERSION_WITH_V to GITHUB_ENV, so the submodule-version check added
in #1391 compared against an empty string and failed every tagged release
(v0.14.0b4: 'AW release major.minor ()').

Export VERSION_NO_V in both the Qt and Tauri jobs, and make the check fail
with an explicit message if the variable is empty instead of blaming the
submodule.

Fixes #1402
---
 .github/workflows/release.yml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 3abdfb693..39c131906 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -300,6 +300,7 @@ jobs:
           VERSION_WITH_V="${VERSION_WITH_V%-research}"
           VERSION_NO_V="${VERSION_WITH_V#v}"
           echo "VERSION_WITH_V=${VERSION_WITH_V}" >> "$GITHUB_ENV"
+          echo "VERSION_NO_V=${VERSION_NO_V}" >> "$GITHUB_ENV"
           echo "========================================"
           echo "Build Version Information"
           echo "========================================"
@@ -328,6 +329,10 @@ jobs:
           fi
 
           AW_VERSION="${VERSION_NO_V}"  # e.g. "0.14.0b3"
+          if [ -z "$AW_VERSION" ]; then
+            echo "ERROR: VERSION_NO_V is empty — the 'Determine and output version' step must export it to GITHUB_ENV" >&2
+            exit 1
+          fi
           AW_MAJOR_MINOR=$(echo "$AW_VERSION" | cut -d'.' -f1-2)  # "0.14"
           AWS_MAJOR_MINOR=$(echo "$BUNDLED_VERSION" | cut -d'.' -f1-2)  # "0.14"
 
@@ -572,6 +577,7 @@ jobs:
           VERSION_WITH_V="${VERSION_WITH_V%-research}"
           VERSION_NO_V="${VERSION_WITH_V#v}"
           echo "VERSION_WITH_V=${VERSION_WITH_V}" >> "$GITHUB_ENV"
+          echo "VERSION_NO_V=${VERSION_NO_V}" >> "$GITHUB_ENV"
           echo "========================================"
           echo "Build Version Information (Tauri)"
           echo "========================================"
@@ -600,6 +606,10 @@ jobs:
           fi
 
           AW_VERSION="${VERSION_NO_V}"  # e.g. "0.14.0b3"
+          if [ -z "$AW_VERSION" ]; then
+            echo "ERROR: VERSION_NO_V is empty — the 'Determine and output version' step must export it to GITHUB_ENV" >&2
+            exit 1
+          fi
           AW_MAJOR_MINOR=$(echo "$AW_VERSION" | cut -d'.' -f1-2)  # "0.14"
           AWS_MAJOR_MINOR=$(echo "$BUNDLED_VERSION" | cut -d'.' -f1-2)  # "0.14"