Skip to content

Commit 43b8aa9

Browse files
authored
ci: Add CI test for MSVS 2026 (#5060)
And some minor fixes discovered along the way. --------- Signed-off-by: Larry Gritz <lg@larrygritz.com>
1 parent 5125c96 commit 43b8aa9

4 files changed

Lines changed: 23 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,17 +686,23 @@ jobs:
686686
- desc: Windows-2022 VS2022
687687
runner: windows-2022
688688
nametag: windows-2022
689-
vsver: 2022
690689
generator: "Visual Studio 17 2022"
691690
python_ver: "3.12"
692691
ctest_test_timeout: "240"
693692
setenvs: export OPENIMAGEIO_PYTHON_LOAD_DLLS_FROM_PATH=1
694693
- desc: Windows-2025 VS2022
695694
runner: windows-2025
696695
nametag: windows-2025
697-
vsver: 2022
698696
generator: "Visual Studio 17 2022"
699697
python_ver: "3.12"
700698
ctest_test_timeout: "240"
701699
setenvs: export OPENIMAGEIO_PYTHON_LOAD_DLLS_FROM_PATH=1
702700
benchmark: 1
701+
- desc: Windows-2025 VS2026
702+
runner: windows-2025-vs2026
703+
nametag: windows-2025-vs2026
704+
generator: "Visual Studio 18 2026"
705+
python_ver: "3.12"
706+
ctest_test_timeout: "240"
707+
setenvs: export OPENIMAGEIO_PYTHON_LOAD_DLLS_FROM_PATH=1
708+
benchmark: 1

src/build-scripts/build_opencolorio.bash

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ OPENCOLORIO_SOURCE_DIR=${OPENCOLORIO_SOURCE_DIR:=${LOCAL_DEPS_DIR}/OpenColorIO}
1919
OPENCOLORIO_BUILD_DIR=${OPENCOLORIO_BUILD_DIR:=${LOCAL_DEPS_DIR}/OpenColorIO-build}
2020
OPENCOLORIO_INSTALL_DIR=${OPENCOLORIO_INSTALL_DIR:=${LOCAL_DEPS_DIR}/dist}
2121
OPENCOLORIO_BUILD_TYPE=${OPENCOLORIO_BUILD_TYPE:=Release}
22-
OPENCOLORIO_CXX=${OPENCOLORIO_CXX:=g++}
23-
OPENCOLORIO_CXX_FLAGS=${OPENCOLORIO_CXX_FLAGS:="-Wno-unused-function -Wno-deprecated-declarations -Wno-cast-qual -Wno-write-strings"}
22+
OPENCOLORIO_CXX=${OPENCOLORIO_CXX:=${CXX}}
23+
OPENCOLORIO_CXX_FLAGS=${OPENCOLORIO_CXX_FLAGS:=}
2424
# Just need libs:
2525
OPENCOLORIO_BUILDOPTS="-DOCIO_BUILD_APPS=OFF -DOCIO_BUILD_NUKE=OFF \
2626
-DOCIO_BUILD_DOCS=OFF -DOCIO_BUILD_TESTS=OFF \

src/build-scripts/gh-win-installdeps.bash

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,18 @@ export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$DEP_DIR/lib:$VCPKG_INSTALLATION_ROOT/i
2424
#ls -l "C:/Program Files (x86)/Microsoft Visual Studio" && true
2525

2626

27-
if [[ "$PYTHON_VERSION" == "3.7" ]] ; then
28-
export CMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH;/c/hostedtoolcache/windows/Python/3.7.9/x64"
29-
export Python_EXECUTABLE="/c/hostedtoolcache/windows/Python/3.7.9/x64/python.exe"
30-
export PYTHONPATH=$OpenImageIO_ROOT/lib/python${PYTHON_VERSION}/site-packages
31-
elif [[ "$PYTHON_VERSION" == "3.9" ]] ; then
27+
if [[ "$PYTHON_VERSION" == "3.9" ]] ; then
3228
export CMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH;/c/hostedtoolcache/windows/Python/3.9.13/x64"
3329
export Python_EXECUTABLE="/c/hostedtoolcache/windows/Python/3.9.13/x64/python3.exe"
3430
export PYTHONPATH=$OpenImageIO_ROOT/lib/python${PYTHON_VERSION}/site-packages
3531
elif [[ "$PYTHON_VERSION" == "3.12" ]] ; then
3632
export CMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH;/c/hostedtoolcache/windows/Python/3.12.10/x64"
3733
export Python_EXECUTABLE="/c/hostedtoolcache/windows/Python/3.12.10/x64/python3.exe"
3834
export PYTHONPATH=$OpenImageIO_ROOT/lib/python${PYTHON_VERSION}/site-packages
35+
elif [[ "$PYTHON_VERSION" == "3.14" ]] ; then
36+
export CMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH;/c/hostedtoolcache/windows/Python/3.14.3/x64"
37+
export Python_EXECUTABLE="/c/hostedtoolcache/windows/Python/3.14.3/x64/python3.exe"
38+
export PYTHONPATH=$OpenImageIO_ROOT/lib/python${PYTHON_VERSION}/site-packages
3939
fi
4040
pip install numpy
4141

@@ -77,6 +77,13 @@ if [[ "$OPENEXR_VERSION" != "" ]] ; then
7777
# the above line is admittedly sketchy
7878
fi
7979

80+
echo "OPENCOLORIO_VERSION='${OPENCOLORIO_VERSION}'"
81+
if [[ "$OPENCOLORIO_VERSION" != "" ]] ; then
82+
OPENCOLORIO_INSTALL_DIR=$DEP_DIR
83+
source src/build-scripts/build_opencolorio.bash
84+
export PATH="$OPENCOLORIO_INSTALL_DIR/bin:$OPENCOLORIO_INSTALL_DIR/lib:$PATH"
85+
fi
86+
8087
cp $DEP_DIR/lib/*.lib $DEP_DIR/bin || true
8188
cp $DEP_DIR/bin/*.dll $DEP_DIR/lib || true
8289
echo "DEP_DIR $DEP_DIR :"

src/cmake/build_expat.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ set (expat_DIR ${expat_ROOT}/lib/cmake/expat-${expat_VERSION})
4747
if (WIN32)
4848
# Set the expat_LIBRARY variable to the full path to ${EXPAT_LIBRARIES}.
4949
# For some reason, find_package(expat) behaves differently on Windows
50-
find_package (EXPAT ${expat_BUILD_VERSION} EXACT REQUIRED)
50+
find_package (expat ${expat_BUILD_VERSION} EXACT REQUIRED)
5151
set_cache(expat_LIBRARY ${EXPAT_LIBRARIES} "Full path to the expat library")
5252
message(STATUS "expat_LIBRARY = ${expat_LIBRARY}")
5353
endif ()

0 commit comments

Comments
 (0)