From 335fa8fde6c2119656dfad103e2dd5274d71ad5e Mon Sep 17 00:00:00 2001 From: Muneerali199 Date: Fri, 13 Mar 2026 15:32:57 +0530 Subject: [PATCH] fix: remove unused declarations (unused_element, unused_field, unused_local_variable) Removes unreferenced private methods, an unused field, an unused local variable, and an unused optional constructor parameter that were flagged by the Dart analyzer across the patient and therapist apps. patient: - daily_activities_screen.dart: remove _animateProgress() and _prevProgress field (method was never called) - appointments_provider.dart: remove _formatTimeOfDay() helper (method was never called) - task_provider.dart: remove _apiStatus field (assigned but never read) therapist: - auth_screen.dart: remove isNewUser local variable (assigned but never read) - consultation_request_detail_screen.dart: remove _buildNotesSection() and _buildDetailRow() (methods were never called) - home_screen.dart: remove _buildConsultationRequestSection() (method was never called) - add_therapy_details_screen.dart: remove super.key from _BuildOptionTile constructor (key param never provided by callers) Closes #199 --- .../activities/daily_activities_screen.dart | 16 ---- .../lib/provider/appointments_provider.dart | 5 -- patient/lib/provider/task_provider.dart | 15 +--- .../lib/presentation/auth/auth_screen.dart | 2 +- .../consultation_request_detail_screen.dart | 79 ------------------- .../lib/presentation/home/home_screen.dart | 53 ------------- .../add_therapy_details_screen.dart | 1 - 7 files changed, 3 insertions(+), 168 deletions(-) diff --git a/patient/lib/presentation/activities/daily_activities_screen.dart b/patient/lib/presentation/activities/daily_activities_screen.dart index 182ba99..a513348 100644 --- a/patient/lib/presentation/activities/daily_activities_screen.dart +++ b/patient/lib/presentation/activities/daily_activities_screen.dart @@ -17,7 +17,6 @@ class _DailyActivitiesScreenState extends State late DateTime today; late AnimationController _progressController; late Animation _progressAnimation; - double _prevProgress = 0.0; @override void initState() { @@ -38,21 +37,6 @@ class _DailyActivitiesScreenState extends State super.dispose(); } - void _animateProgress(double end) { - setState(() { - _progressAnimation = Tween( - begin: _prevProgress, - end: end, - ).animate(CurvedAnimation( - parent: _progressController, - curve: Curves.easeInOut, - )); - - _prevProgress = end; - _progressController.forward(from: 0.0); - }); - } - @override Widget build(BuildContext context) { return Scaffold( diff --git a/patient/lib/provider/appointments_provider.dart b/patient/lib/provider/appointments_provider.dart index 8c05f1d..15e3c2a 100644 --- a/patient/lib/provider/appointments_provider.dart +++ b/patient/lib/provider/appointments_provider.dart @@ -147,11 +147,6 @@ class AppointmentsProvider extends ChangeNotifier { } } - /// Helper method to format `TimeOfDay` into readable string. - String _formatTimeOfDay(TimeOfDay time, BuildContext context) { - return MaterialLocalizations.of(context).formatTimeOfDay(time); - } - // Fetch all appointments from the patient repository Future fetchAllAppointments() async { try { diff --git a/patient/lib/provider/task_provider.dart b/patient/lib/provider/task_provider.dart index 983a406..e8bfb1c 100644 --- a/patient/lib/provider/task_provider.dart +++ b/patient/lib/provider/task_provider.dart @@ -6,7 +6,6 @@ class TaskProvider extends ChangeNotifier { List _allTasks = []; DateTime _selectedDate = DateTime.now(); final PatientRepository _patientRepository; - ApiStatus _apiStatus = ApiStatus.initial; String? _activityId; String? _activitySetId; @@ -19,36 +18,26 @@ class TaskProvider extends ChangeNotifier { DateTime? date, }) async { try { - _apiStatus = ApiStatus.loading; notifyListeners(); final result = await _patientRepository.getTodayActivities(date: date); if(result is ActionResultSuccess) { _allTasks = result.data.$1; _activityId = result.data.$2; _activitySetId = result.data.$3; - _apiStatus = ApiStatus.success; } else { - _apiStatus = ApiStatus.failure; _allTasks = []; } notifyListeners(); } catch(e) { - _apiStatus = ApiStatus.failure; - } finally { notifyListeners(); } } Future updateActivityCompletion(List tasks) async { try { - final result = await _patientRepository.updateActivityCompletion(tasks: _allTasks, activityId: _activityId, activitySetId: _activitySetId); - if(result is ActionResultSuccess) { - _apiStatus = ApiStatus.success; - } else { - _apiStatus = ApiStatus.failure; - } + await _patientRepository.updateActivityCompletion(tasks: _allTasks, activityId: _activityId, activitySetId: _activitySetId); } catch(e) { - _apiStatus = ApiStatus.failure; + notifyListeners(); } finally { notifyListeners(); } diff --git a/therapist/lib/presentation/auth/auth_screen.dart b/therapist/lib/presentation/auth/auth_screen.dart index 46da774..b0ad281 100644 --- a/therapist/lib/presentation/auth/auth_screen.dart +++ b/therapist/lib/presentation/auth/auth_screen.dart @@ -45,7 +45,7 @@ class _AuthScreenState extends State { final authProvider = Provider.of(context, listen: false); await authProvider.checkAuthentication(); - final isNewUser = await authProvider.checkIfUserIsNew(); + await authProvider.checkIfUserIsNew(); final fullName = session.user.userMetadata?['full_name']; final email = session.user.email ?? 'Unknown User'; diff --git a/therapist/lib/presentation/consultation/consultation_request_detail_screen.dart b/therapist/lib/presentation/consultation/consultation_request_detail_screen.dart index 5f293b4..578de75 100644 --- a/therapist/lib/presentation/consultation/consultation_request_detail_screen.dart +++ b/therapist/lib/presentation/consultation/consultation_request_detail_screen.dart @@ -372,49 +372,6 @@ class _ConsultationRequestDetailScreenState ); } - Widget _buildNotesSection() { - return Padding( - padding: const EdgeInsets.symmetric(horizontal: 20, vertical: 16), - child: Column( - crossAxisAlignment: CrossAxisAlignment.start, - children: [ - _buildSectionTitle('Patient Note'), - const SizedBox(height: 12), - Container( - width: double.infinity, - padding: const EdgeInsets.all(16), - decoration: BoxDecoration( - color: Colors.grey[50], - borderRadius: BorderRadius.circular(12), - border: Border.all(color: Colors.grey.withOpacity(0.2)), - ), - child: Row( - crossAxisAlignment: CrossAxisAlignment.start, - children: [ - Icon( - Icons.format_quote, - color: const Color(0xFF6A1B9A).withOpacity(0.7), - size: 24, - ), - const SizedBox(width: 12), - // Expanded( - // child: Text( - // widget.request.notes!, - // style: const TextStyle( - // fontSize: 15, - // height: 1.5, - // fontStyle: FontStyle.italic, - // ), - // ), - // ), - ], - ), - ), - ], - ), - ); - } - Widget _buildActionButtons() { return Container( padding: const EdgeInsets.all(20), @@ -480,42 +437,6 @@ class _ConsultationRequestDetailScreenState ); } - Widget _buildDetailRow(String label, String value, IconData icon) { - return Row( - crossAxisAlignment: CrossAxisAlignment.start, - children: [ - Icon( - icon, - size: 20, - color: const Color(0xFF6A1B9A).withOpacity(0.7), - ), - const SizedBox(width: 12), - Expanded( - child: Column( - crossAxisAlignment: CrossAxisAlignment.start, - children: [ - Text( - label, - style: TextStyle( - fontSize: 14, - color: Colors.grey[600], - ), - ), - const SizedBox(height: 4), - Text( - value, - style: const TextStyle( - fontSize: 16, - fontWeight: FontWeight.w500, - ), - ), - ], - ), - ), - ], - ); - } - void _showAcceptDialog() { showDialog( context: context, diff --git a/therapist/lib/presentation/home/home_screen.dart b/therapist/lib/presentation/home/home_screen.dart index a30e396..5547d90 100644 --- a/therapist/lib/presentation/home/home_screen.dart +++ b/therapist/lib/presentation/home/home_screen.dart @@ -282,57 +282,4 @@ class HomeContent extends StatelessWidget { ), ); } - - Widget _buildConsultationRequestSection(BuildContext context) { - return Consumer( - builder: (context, provider, _) { - // Check if provider is initialized and has data - if (provider.isLoading) { - return const Center(child: CircularProgressIndicator()); - } - - if (provider.error != null) { - return Center(child: Text('${provider.error}')); - } - - if (provider.pendingRequests.isEmpty) { - return const SizedBox.shrink(); // Don't show section if no pending requests - } - - return Column( - crossAxisAlignment: CrossAxisAlignment.start, - children: [ - Row( - mainAxisAlignment: MainAxisAlignment.spaceBetween, - children: [ - const Text( - 'Pending Consultations', - style: TextStyle( - fontSize: 18, - fontWeight: FontWeight.bold, - ), - ), - TextButton( - onPressed: () { - Navigator.push( - context, - MaterialPageRoute( - builder: (_) => const ConsultationRequestsScreen(), - ), - ); - }, - child: const Text('View All'), - ), - ], - ), - const SizedBox(height: 12), - SizedBox( - height: 140, - child: PendingRequestView(pendingRequest: provider.pendingRequests) - ), - ], - ); - }, - ); - } } diff --git a/therapist/lib/presentation/therapy_goals/add_therapy_details_screen.dart b/therapist/lib/presentation/therapy_goals/add_therapy_details_screen.dart index 6768277..b1ca81f 100644 --- a/therapist/lib/presentation/therapy_goals/add_therapy_details_screen.dart +++ b/therapist/lib/presentation/therapy_goals/add_therapy_details_screen.dart @@ -232,7 +232,6 @@ class _AddTherapyDetailsScreenState extends State { class _BuildOptionTile extends StatelessWidget { const _BuildOptionTile({ - super.key, required this.name, required this.isSelected, required this.onChanged,