From 9eed6f9e1ece1d90ce033786076225346f3cc768 Mon Sep 17 00:00:00 2001 From: Jim Risen Date: Sun, 27 Sep 2026 02:50:53 +0300 Subject: [PATCH 1/2] feat: export TChartGroupLoaderProps Every other component exports its props type - TSciChartGroupProps, ISciChartNestedLegendProps - but ChartGroupLoader's was declared locally, so consumers had no way to name it when wrapping the component or typing their own props. --- CHANGELOG.md | 7 +++++++ src/ChartGroupLoader.tsx | 3 ++- src/index.ts | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ef03483..ae50d74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,10 @@ This file is not shipped in the npm package — the tarball root is `lib/`, whic ## [Unreleased] +### Added + +- `TChartGroupLoaderProps` is exported, matching every other component's props type. + ### Fixed - The import-time `wasmUrl: "/scichart.wasm"` default could overwrite the app's own @@ -17,6 +21,9 @@ This file is not shipped in the npm package — the tarball root is `lib/`, whic evaluated after it. The default is now applied only while `SciChartSurface.isWasmConfigured` is false, so the app's configuration wins in either order. Requires scichart 6.0.8, which adds that flag. +- `SciChartMemoryDebugWrapper` rendered its children inside a `position: fixed` box, which + collapsed percentage-based sizing and put anything below the fold out of reach of scrolling. + The controls are `sticky` now and the children render in normal flow. ### Changed diff --git a/src/ChartGroupLoader.tsx b/src/ChartGroupLoader.tsx index 9972bbf..2a7c3e4 100644 --- a/src/ChartGroupLoader.tsx +++ b/src/ChartGroupLoader.tsx @@ -6,7 +6,8 @@ import { SciChartGroup } from "./SciChartGroup"; import { IInitResult } from "./types"; type TDivProps = DetailedHTMLProps, HTMLDivElement>; -type TChartGroupLoaderProps = TDivProps & { +/** Props for {@link ChartGroupLoader}: a div's own props, plus the group's loading and init hooks. */ +export type TChartGroupLoaderProps = TDivProps & { fallback?: ReactNode | undefined; onInit?: (chartInitResults: IInitResult[]) => void; onInitError?: (error: any) => void; diff --git a/src/index.ts b/src/index.ts index 90bce76..2d7e801 100644 --- a/src/index.ts +++ b/src/index.ts @@ -1,4 +1,5 @@ // This file is generated by generate-exports-file.ts script, do not edit it manually! +export type { TChartGroupLoaderProps } from "./ChartGroupLoader"; export { ChartGroupLoader } from "./ChartGroupLoader"; export { DefaultFallback } from "./DefaultFallback"; export { SciChartReact } from "./SciChart"; From 99b1000cad711ff3a181abefc808ed79158c1cda Mon Sep 17 00:00:00 2001 From: Jim Risen Date: Tue, 20 Oct 2026 17:07:18 +0300 Subject: [PATCH 2/2] fix(SciChartMemoryDebugWrapper): keep children in normal flow --- src/SciChartMemoryDebugWrapper.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/SciChartMemoryDebugWrapper.tsx b/src/SciChartMemoryDebugWrapper.tsx index 580846b..82aca70 100644 --- a/src/SciChartMemoryDebugWrapper.tsx +++ b/src/SciChartMemoryDebugWrapper.tsx @@ -35,13 +35,17 @@ export function SciChartMemoryDebugWrapper( return ( <> -
+ {/* Sticky rather than fixed, and the children sit outside it. A fixed box with no + width shrink-wraps to its content, so children rendered inside it lost their + sizing - a chart asking for a percentage width resolved it against the collapsed + box - and, being out of flow, anything below the fold could not be scrolled to. + Sticky keeps the controls in view while leaving the children in normal flow. */} +
Render Child Components Tree
-
- {drawChart ? props.children : null}
+ {drawChart ? props.children : null} ); }