Make color selector docker scale better

[EmiOnGit]

First of, thanks for this awesome plugin :)

Currently, my largest and only problem with the plugin is the unnatural large amount of horizontal space the docker needs.
After fiddeling with the code I noticed that the main cause is the row displaying the different colorspaces.
I can untick some colorspaces that I don't care for in the settings but this is not persistent after a krita restart. (I can make a new issue for that if wanted)

A common solution to reduce the amount of elements in other docker is to use a dropdown list instead.

The other limiting factor of docker width are the component sliders under the colorspace.
To be honest I don't think there is much we could do about them besides changing them to be listed vertically whenever they become the limiting factor for horizontal space.

Feel free to tell me your thoughts and if I can help with something :]

Current minimal width of the widget:

Minimal width without the widget:

(Using linux with the flatpack AppImage)

[443eb9]

Hi, you mentioned

I can untick some colorspaces that I don't care for in the settings but this is not persistent after a krita restart.

But this is not the expected behavior. The plugin should remember which color models you've enabled, as well as their order. Can you go to kritarc , search for displayOrder, then send me its value?

You can also try to remove the entire [Extended Color Selector] section, then disable some models and restart to see if it's remembering your settings.

to use a dropdown list instead.

I think there will is a more elegant solution. I can create a setting in global settings, and allow user to choose whether to display these buttons horizontally, vertically at left/right, or using dropdown list. I personally prefer to use only 3 of them, so maybe I'd like to display them horizontally. This will be shipped with the next version.

[EmiOnGit]

Giving the end user all 3 options is definitely the most elegant but also the most troublesome to keep up to date. I would gladly appreciate it though :)

Interesting to find out that my behavior is not expected.
I did some further testing and observed that removing [Extended Color Selection] does not change my behavior.
As you can see in the screenshot below the portable color selector width of 393 got written under the globals. The displayOrder doesn't seem to change no matter the approach for me.

Even more interesting, when I change the displayOrder manually after closing krita, it get restored to its default once I start krita.
At this point it might be interesting to have another person test this behavior to see if it is a problem with my setup specifically even though I doubt that.

[EmiOnGit]

I also just noticed that the component selection of the colorspace (R, G, B) in case of RGB doesn't persist after a krita restart. Just wanted to add that since I'd also guess this is unexpected too and might be a related system.

[443eb9]

Hi, 0.5.0 was just released, and is rewritten using cpp. The plugin dock looks slightly different and I'm not sure if the improvement we disscussrd here was still necessary.

And does the unexpeted restoration still persists?

Please feel free to share more ideas.

[EmiOnGit]

I just tried it out and .. sadly the plugin can not initialize because it fails to find the libkritaui library, which you link against dynamically in your extendedcolorselector.so.

I don't know the krita infrastructure but I can debug the error in a couple of days if you don't see what might have been wrong.

I'll paste the section of my output that might be relevant.

Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
/tmp/.mount_krita-nIIoIM/usr/lib/krita-python-libs/krita added to PYTHONPATH
krita.scripting: "Traceback (most recent call last):"
krita.scripting: "  File \"/home/emi/.local/share/krita/pykrita/extended_color_selector/__init__.py\", line 1, in <module>"
krita.scripting: "    from .extension import ExtendedColorSelector"
krita.scripting: "  File \"/home/emi/.local/share/krita/pykrita/extended_color_selector/extension.py\", line 81, in <module>"
krita.scripting: "    Krita.instance().addExtension(ExtendedColorSelector(Krita.instance()))"
krita.scripting: "  File \"/home/emi/.local/share/krita/pykrita/extended_color_selector/extension.py\", line 64, in __init__"
krita.scripting: "    raise RuntimeError("
krita.scripting: "RuntimeError: Failed to load ExtendedColorSelector library from /home/emi/.local/share/krita/pykrita/extended_color_selector/lib/extendedcolorselector.so: libkritaui.so.20: cannot open shared object file: No such file or directory"
krita.scripting: "Could not import extended_color_selector"
krita.scripting: Error loading plugin "extended_color_selector"
Warning: requested data for unknown action "path-break-at-selection"

Also good job on porting it over to c++. Must have been a ton of work! :)

[443eb9]

I built 0.5.0 with 5.3.0-prealpha source tree and I thought it should work for 5.2.13, but actually, it didn't. 🥲 Sorry for the trouble. You may need to download the binary for 5.2.13.

Edit: Accidentally clicked on the close issue button.