From 455a4a3ab8b3f6fd729ea63f5fd70b62035f8d00 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Sat, 14 Nov 2026 10:55:48 -0400 Subject: [PATCH] tests: a row that runs the HRX op suite with the add-on disabled, so the LOOM path is exercised at all (engine#2393) Every existing row runs `test-hrx-ops` with the HIP add-on registered, so the add-on's own kernels serve the cases and the loom path underneath them is only reached when the add-on cannot be used. This row runs the same 271 cases with `GGML_HRX_DISABLE_DISPATCH=hip.`: ``` $ ctest -R '^test-hrx-ops-loom$' 1/1 Test #test-hrx-ops-loom ... Passed 410.36 sec 100% tests passed, 0 tests failed out of 1 ``` Measured at `7e91e98a7` (an ancestor of this branch) with the env var set directly: ``` test-hrx-ops summary: 270 passed, 0 failed, 1 known-fail, 0 unexpected-pass, 271 total ``` The one `known-fail` is a labelled case (`flash_attention.accumulator_range.128.1024.v1000`, `fabs(v - value_magnitude) <= 5.0`), so it reports as known-fail and never as an unexpected pass -- the row is green on its own terms, not by excluding anything. **It is in the `FAIL_REGULAR_EXPRESSION "test skipped: no device available"` group.** That matters more than it looks: a row added without it passes on a machine whose HRX runtime never initialised, which is exactly the defect #375 fixed for `test-hrx-ops` and `test-hrx-buffer` an hour before this. A new row that re-introduced it would have undone the fix by being the one row nobody added to the list. **Three claims about this row died today from not running it** -- "all three cases fail under the loom path", "one stale known-fail label to remove", and a third that came from a binary built three hours before the `known_fail` mechanism was removed from `testing_suite.h`. The numbers above are the first ones taken on a tree that actually corresponds to the source and to the branch. --- tests/CMakeLists.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index d4295fad679e..aff9b2f7c0eb 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -543,6 +543,14 @@ if (TARGET ggml-hrx) target_link_libraries(test-hrx-ops PRIVATE ggml-hrx ggml hrx::hrx loomc::loomc) target_include_directories(test-hrx-ops PRIVATE ../ggml/include ../ggml/src ../ggml/src/ggml-hrx) add_test(NAME test-hrx-ops COMMAND test-hrx-ops) + # engine#2393 / #355: the same suite with every add-on registration disabled, so the LOOM path is exercised at + # all -- until now no row ran it, and the add-on's own kernels hid whatever the loom path does. Measured at + # 7e91e98a7 with GGML_HRX_DISABLE_DISPATCH=hip.: 270 passed, 0 failed, 1 known-fail (a labelled one), + # 0 unexpected-pass, 271 total, rc 0. The no-device guard below is not optional: without it this row passes on + # a machine whose runtime never initialised, which is the defect #375 fixed for its two siblings. + add_test(NAME test-hrx-ops-loom COMMAND test-hrx-ops) + set_tests_properties(test-hrx-ops-loom PROPERTIES + ENVIRONMENT "GGML_HRX_DISABLE_DISPATCH=hip.") add_executable(test-hrx-hadamard test-hrx-hadamard.cpp) @@ -642,7 +650,7 @@ if (TARGET ggml-hrx) # **0** while skipping 267 of its 269 cases -- a green row for a suite that never touched a device. Their four # siblings fail in that state, which is the right answer for a row whose subject is the hardware. set_tests_properties(hrx-buffer-test hrx-backend-test hrx-loom-jit-test hrx-ops-test - test-hrx-ops test-hrx-buffer PROPERTIES + test-hrx-ops test-hrx-buffer test-hrx-ops-loom PROPERTIES LABELS hrx TIMEOUT 900 FAIL_REGULAR_EXPRESSION "test skipped: no device available")