From f299d8a78c63485077541655dd7c13425d294624 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Fri, 13 Nov 2026 21:27:10 -0400 Subject: [PATCH] tests: an add-on build also runs hrx-backend-test on the Loom path (engine#2392) With a HIP add-on built in, its matchers claim nodes whose Loom-path plan many host cases assert, so an add-on build never checked the Loom path at all. Register hrx-backend-test-loom in that configuration: the same binary with GGML_HRX_DISABLE_DISPATCH=hip. (every add-on registration is named hip.*). Co-Authored-By: Claude Opus 5.5 --- tests/CMakeLists.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index e1b0ab006686..a635b8e7b1f5 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -490,6 +490,17 @@ if (TARGET ggml-hrx) target_include_directories(hrx-backend-test PRIVATE ../ggml/include ../ggml/src ../ggml/src/ggml-hrx) # our line's hrx-backend-test takes case names as its only arguments (no test_runner::Suite flags) add_test(NAME hrx-backend-test COMMAND hrx-backend-test) + if (GGML_HRX_HIP_ADDON_DIR) + # engine#2392: with a HIP add-on built in, its matchers claim nodes whose Loom-path plan many host cases + # assert, so an add-on build otherwise never checks the Loom path at all. This runs the same suite with every + # add-on registration (all named hip.*) switched off; measured 87/0 host, 14/14 device at 5006d9308. + add_test(NAME hrx-backend-test-loom COMMAND hrx-backend-test) + set_tests_properties(hrx-backend-test-loom PROPERTIES + ENVIRONMENT "GGML_HRX_DISABLE_DISPATCH=hip." + LABELS hrx + TIMEOUT 900 + FAIL_REGULAR_EXPRESSION "test skipped: no device available") + endif() # our line's Loom JIT suite (the base's ctest row); AMD's hrx-loom-jit-test is a different file add_executable(test-hrx-loom-jit test-hrx-loom-jit.cpp)