From 6d5a6756c92dd4781c9fe853ed21438a25a7c3cd Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Mon, 16 Nov 2026 07:15:19 -0400 Subject: [PATCH] hw-gate: the manifest says what recorded_at can and cannot mean (engine#2643) #2643 measured that five of six goldens name a llama.cpp commit in a history disjoint from the pinned fork, and concluded that 'the question cannot be asked' of those bases. Three options were put: re-record them, say in the manifest that the label is provenance only, or print both shas on the verdict line. The third shipped in #2644 (provenance(), printed in brackets on the KLD verdict). This is the second, which needs no device and no decision. The about string now says recorded_at is provenance, that it may name a commit no longer reachable from the current pin, and that judge prints the relation rather than guessing -- 'cannot place' is the answer when it cannot place. One constant (ABOUT) feeds both the template in load() and the shipped tests/golden/hw-gate/manifest.json, so the two cannot drift: a reader of either artifact learns the same thing about the field they are looking at. No behaviour change. judge still runs (verified: it reaches the log check), the manifest still parses, and 'recorded_at' is not consumed by anything but the writer and provenance() -- grep confirms no test or doc asserts the old wording. --- tests/golden/hw-gate/manifest.json | 2 +- tools/hw_gate_manifest.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/golden/hw-gate/manifest.json b/tests/golden/hw-gate/manifest.json index 673823d26..ae4620d96 100644 --- a/tests/golden/hw-gate/manifest.json +++ b/tests/golden/hw-gate/manifest.json @@ -1,5 +1,5 @@ { - "about": "HRX hardware gate KLD bases (docs/hw-gate.md). The .kld files live on the gate box, not in git; this file pins what they are.", + "about": "HRX hardware gate KLD bases (docs/hw-gate.md). The .kld files live on the gate box, not in git; this file pins what they are. `recorded_at` names the tree each base was measured at: it is provenance, and it may name a commit that is no longer reachable from the current pin (engine#2643) -- `tools/hw_gate_manifest.py judge` prints how the golden's tree relates to the tested one on the verdict line, and says \"cannot place\" rather than guessing when it cannot.", "kld": { "qwen3-0.6b": { "args": "-c 512 --chunks 8 -b 512 -ub 512 --device HRX0 -ngl 99", diff --git a/tools/hw_gate_manifest.py b/tools/hw_gate_manifest.py index 67a03feda..1dc32075b 100644 --- a/tools/hw_gate_manifest.py +++ b/tools/hw_gate_manifest.py @@ -82,12 +82,13 @@ def pins(root): return out +ABOUT = 'HRX hardware gate KLD bases (docs/hw-gate.md). The .kld files live on the gate box, not in git; this file pins what they are. `recorded_at` names the tree each base was measured at: it is provenance, and it may name a commit that is no longer reachable from the current pin (engine#2643) -- `tools/hw_gate_manifest.py judge` prints how the golden\'s tree relates to the tested one on the verdict line, and says "cannot place" rather than guessing when it cannot.' # engine#2643: one string for the template and the shipped manifest, so a reader of either learns what recorded_at can and cannot mean. + def load(path): if os.path.exists(path): with open(path) as f: return json.load(f) - return {"about": "HRX hardware gate KLD bases (docs/hw-gate.md). The .kld files live on the gate box, " - "not in git; this file pins what they are.", "kld": {}} + return {"about": ABOUT, "kld": {}} def cmd_set(manifest, name, base, model, text):