From eb731e59c48b41e9766fc88867987833bfb46300 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Sun, 15 Nov 2026 06:37:13 -0400 Subject: [PATCH] hw-gate: a model or corpus this runner does not have is a SKIP, not a FAIL (engine#2501) The qwen3-coder-30b-a3b row fails in 0s with 'model missing' because the 30 GiB GGUF is not on the gate runner, so every PR's gate carries a red that says nothing about the PR. Same for a missing kld corpus. The distinction the status should carry: - 'not provisioned on this runner' -- a fact about the machine, says nothing about the code: SKIP, plus a ::warning:: so it is visible in the log rather than inferred from an absent row; - 'tried and could not' -- memory pre-check refused, kld verify failed, rc 75: FAIL, and those keep infra=1 because they red the whole gate, which is right for them. Verified: bash -n clean; the four remaining infra=1 sites are all tried-and-could-not (404, 653, 743, 787). Not verified by running the gate: it acquires a gpu-hold before the model loop, so exercising this path needs a free card -- which is itself worth noting (see the PR body). --- scripts/hw-gate.sh | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/hw-gate.sh b/scripts/hw-gate.sh index 51c46f447..f7377a0ad 100755 --- a/scripts/hw-gate.sh +++ b/scripts/hw-gate.sh @@ -631,11 +631,19 @@ fi # ---- kat + needle + KLD: one step per model ----------------------------------------------- if has kat || has needle || has kld; then - [ -f "$TEXT" ] || { has kld && { result kld FAIL 0 "text missing: $TEXT"; infra=1; }; } + # A corpus that is not on this runner says nothing about the PR (engine#2501). SKIP + a warning, not infra: + # `infra` reds the whole gate, which is right for "tried and could not" and wrong for "was never here". + [ -f "$TEXT" ] || { has kld && { result kld SKIP 0 "text missing: $TEXT (not provisioned)"; note "::warning::hw-gate: kld corpus not provisioned: $TEXT"; }; } while IFS='|' read -r name file repeat donee srvargs; do want_model "$name" || continue model=$MODELS/$file base=$STORE/kld/$name.kld - if [ ! -f "$model" ]; then result "model $name" FAIL 0 "model missing: $model"; infra=1; continue; fi + if [ ! -f "$model" ]; then + # Same rule as the corpus above (engine#2501): the GGUF is absent from THIS runner, which is not a + # finding about the PR. SKIP, warn, and let the rest of the gate speak. + result "model $name" SKIP 0 "model missing: $model (not provisioned)" + note "::warning::hw-gate: model not provisioned on this runner: $model" + continue + fi dokat=0; has kat && dokat=1 needle=0; [ "$donee" = 1 ] && has needle && needle=1 dokld=0; has kld && [ -f "$TEXT" ] && [ -z "$srvargs" ] && dokld=1