From 274c78fff13d642cb9a864d03032a47c555d5a83 Mon Sep 17 00:00:00 2001 From: bcloud Date: Sat, 14 Nov 2026 12:37:29 -0400 Subject: [PATCH] hw-gate: give the f16 audit the gpu-kernels CHECKOUT, not the addon directory MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #2439 wired the add-on f16 audit into the one flow that has the tree -- correct, and it merged with a path that makes it fail on every run: addon=$(fetch-private.sh ... "$STORE/gpu-kernels") # echoes "$dest/$path" = .../gpu-kernels/addons/hip-hrx python3 tools/ci/hip_f16_audit.py --dir "$addon" ... --dir is the tree the audit walks, and its subject is /addons/hip-hrx/kernels. Handed $addon it looks for /addons/hip-hrx/kernels, refuses, and the block turns the refusal into a failed gate: before --dir /addons/hip-hrx rc=2 "…/addons/hip-hrx/addons/hip-hrx/kernels is not a directory - cannot tell, and that is not a pass" after --dir rc=0 3 kernel file(s), no f16 accumulator; 4 narrowing(s) So every HW_GATE_PRIVATE=1 run would have reported "the gpu-kernels add-on at fails the f16 audit" with the kernels fine, and exited 2. Measured as a pair on one tree with the same fixtures, one ticket not needed. --expect-sha "$addon_pin" is unchanged and still the right gate: the checkout fetch-private just populated is asserted against the pin it fetched, rather than trusting the directory. --- scripts/hw-gate.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/hw-gate.sh b/scripts/hw-gate.sh index 8902b9c22..ace7926c9 100755 --- a/scripts/hw-gate.sh +++ b/scripts/hw-gate.sh @@ -456,7 +456,12 @@ if [ -z "$BIN" ]; then # nothing ran it: the ratchet walks *.loom only, and this is the one flow that already has the tree (CI has # no checkout, so its row always takes the 77 path). Auditing here is the "on a pin bump" moment, and # --expect-sha makes it refuse a tree that is not the pin it just fetched rather than reporting clean. - if ! python3 "$ROOT/tools/ci/hip_f16_audit.py" --dir "$addon" --expect-sha "$addon_pin" > "$OUT/hip-f16-audit.txt" 2>&1; then + # --dir is the gpu-kernels CHECKOUT, not "$addon": fetch-private.sh echoes "$dest/$path", i.e. .../addons/hip-hrx, + # which is the -DGGML_HRX_HIP_ADDON_DIR argument. The audit walks /addons/hip-hrx/kernels, so handing it + # $addon made it look for .../addons/hip-hrx/addons/hip-hrx/kernels, refuse ("cannot tell, and that is not a + # pass"), and this block turns that refusal into a failed gate -- on every run, with a message blaming the + # kernels. engine#2439's own CHANGES called for the audit; the path is what makes it fire at all. + if ! python3 "$ROOT/tools/ci/hip_f16_audit.py" --dir "$STORE/gpu-kernels" --expect-sha "$addon_pin" > "$OUT/hip-f16-audit.txt" 2>&1; then note "::error::the gpu-kernels add-on at ${addon_pin:0:12} fails the f16 audit (see hip-f16-audit.txt)" sed -n '1,6p' "$OUT/hip-f16-audit.txt" | sed 's/^/ /' exit 2