From bb2e8a57376e8c169d7808c973c1cc0ba6dd5981 Mon Sep 17 00:00:00 2001 From: bcloud Date: Sat, 14 Nov 2026 08:21:53 -0400 Subject: [PATCH] third_party/llama.cpp: pin to 59967468e -- six commits, including the MTP-drafter crash fix The engine pins ea2d2eb07. The fork is six commits ahead and every one of them matters to something this lane has measured today: a110cca #370 alignas on the imported-buffer fixture, and the is_host relaxation 60f7446 #371 an imported buffer is a window on an allocation, not a retagged CPU buffer bfdb4d4 #373 restore #357's async host-buffer fallback and the misaligned-pointer refusal 7e91e98 #374 a mapped weight is a window too, not a retagged CPU buffer d9d7696 #342 the q4_0 V-cache refusal's MESSAGE named a writer that had since merged 5996746 #376 restore the two MTP-drafter pieces #376 is the one that makes this urgent: without it llama-server SIGSEGVs on any MTP request. Measured on gfx1151 with the real Qwen3.8-27B UD-Q4_K_XL, one request per run, llama.cpp#379's own regression arm: 7e91e98a7 (pre-#376) SIGSEGV in the drafter, http=000, no acceptance line 59967468e http=200, draft acceptance 0.64286 (9 accepted / 14 generated), mean len 2.80 so a pin at 7e91e98a7 would carry every buffer fix and still ship a server that crashes the moment MTP drafting is enabled. Verified at 59967468e, gfx1151: hrx-buffer-test 9 passed, 0 failed, 0 known-fail, 0 unexpected-pass, 9 total (one gpu-hold ticket) MTP request http=200, acceptance 0.64286, mean len 2.80 (llama.cpp#379's arm) engine build CFG=0 BUILD=0, 136 targets, 0 errors (today's main + this submodule) The registry moves with the pin. registry/architectures.json records the llama.cpp pin, so a submodule bump without regenerating it fails ctest `registry_pins` -- `llama.cpp (hrx) recorded at ea2d2eb07, pinned at 59967468e`, which is the one ask on this PR's first CHANGES verdict. Folded into this commit rather than a follow-up, as asked: tools/registry_build.py -> registry/architectures.json (hrx 350, npu 9, architectures 350, mapped 350) tools/registry_build.py --check-pins -> rc 0, "records the committed pins" The regenerated file differs from the committed one by exactly the pin line (4 diff lines, one value), so nothing else in the registry was rewritten. Checked rather than assumed, as before: .loom corpus across the range 0 files changed f16 ratchet fingerprint b9b121a5ddc51854 (326 .loom) at both ends -- NO baseline change header changes in the range additive only; the engine includes neither header gitlink sha 59967468e9cb0f19f9535a04aa09e4166a002d8c, confirmed with git cat-file -e Extended at cl-hrxkern's request on this PR ("move this pin to fork 59967468e instead of opening a second bump"), which is the right call: two bumps for one branch head is how a pin trail becomes a pin essay. --- registry/architectures.json | 2 +- third_party/llama.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/registry/architectures.json b/registry/architectures.json index 8fab93d86..db1cd6526 100644 --- a/registry/architectures.json +++ b/registry/architectures.json @@ -1,7 +1,7 @@ { "about": "HF architecture -> GGUF architecture and the backends whose code accepts it. Generated by tools/registry_build.py from the pinned sources; do not edit.", "sources": { - "llama.cpp (hrx)": "ea2d2eb07d5131b2926ee52bbd8cf681a311eb05" + "llama.cpp (hrx)": "59967468e9cb0f19f9535a04aa09e4166a002d8c" }, "counts": { "hrx": 350, diff --git a/third_party/llama.cpp b/third_party/llama.cpp index ea2d2eb07..59967468e 160000 --- a/third_party/llama.cpp +++ b/third_party/llama.cpp @@ -1 +1 @@ -Subproject commit ea2d2eb07d5131b2926ee52bbd8cf681a311eb05 +Subproject commit 59967468e9cb0f19f9535a04aa09e4166a002d8c