From df8285d61c32b9585e6f8ed65e6313bde30c1edc Mon Sep 17 00:00:00 2001 From: bcloud Date: Sat, 14 Nov 2026 02:53:27 -0400 Subject: [PATCH] tools/ci: the f16 ratchet states its scope on the green line, not only in the docstring A PASS from this tool reads as "the HRX kernels are clean", and it is clean over the Loom corpus only. The HIP add-on's kernels are .hip/.cpp in the gpu-kernels repo and are never scanned, so a gpu-kernels pin bump is invisible to this check. That is not hypothetical: engine#2405's bump (b0ed206 -> 965936607) added 1,116 lines of new .hip -- moe_down_q4k, moe_down_q6k, fa_prompt_q8w -- and all three had to be audited by hand for the f16 accumulator class this tool exists to catch. They were clean (f32 accumulators, one narrowing at the output), but nothing in CI would have said so. The line prints on success, beside the counts, so the scope travels with the verdict rather than living in a docstring nobody reads at the moment they trust the green. hrx_f16_narrowing: 84 narrowing body(ies), none new, none stale; ... hrx_f16_narrowing: scope = .loom bodies under that corpus ONLY; gpu-kernels add-on kernels (.hip/.cpp, a separate repo) are NOT scanned -- audit those on a pin bump (engine#2405) No behaviour change: same exit codes, same checks, --self-test passes, and the FAIL path is untouched (a failure already names what is wrong; this line is for the case where a reader has nothing else to go on). --- tools/ci/hrx_f16_narrowing.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/ci/hrx_f16_narrowing.py b/tools/ci/hrx_f16_narrowing.py index 9f897f189..7f6a1956c 100755 --- a/tools/ci/hrx_f16_narrowing.py +++ b/tools/ci/hrx_f16_narrowing.py @@ -308,6 +308,12 @@ def check(root, corpus=None): f"{len(acc_baseline)} f16 accumulator body(ies), none new, none stale; " f"{len(guard)} of the narrowing bodies carry a guard marker" + (f" ({', '.join(sorted(guard))})" if guard else " (the guard sits on the producer, engine#1962)")) + # State the scope on the green line, not only in the docstring. A PASS here is read as "the HRX kernels are + # clean", and it is clean over the Loom corpus only: the HIP add-on's kernels live in the gpu-kernels repo as + # .hip/.cpp and are never scanned. A gpu-kernels pin bump is therefore invisible to this check (engine#2405), + # and the one that prompted this line added 1,116 lines of new .hip that had to be audited by hand. + print("hrx_f16_narrowing: scope = .loom bodies under that corpus ONLY; gpu-kernels add-on kernels " + "(.hip/.cpp, a separate repo) are NOT scanned -- audit those on a pin bump (engine#2405)") return 0