From 4fcc7694993d8d83e98a728f91ee44c876097f0e Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Fri, 13 Nov 2026 03:10:26 -0400 Subject: [PATCH] pre-pr-checks: the one check that is not a command -- build the target your file is in `docs/pre-pr-checks.md` lists six host-side commands and says why a green `build` tick is not a substitute for them. It does not cover the failure I actually caused, so this adds the seventh thing, in its own section because it is not a command: 2327, this session: the image refusal added a 400 body to app/forward_serve.cpp, one brace short. The PR's unit test built and passed -- it covered `npu::message_carries_an_image()`, the *predicate*. The PR merged, `main` did not compile, and another lane fixed it in 273f6e9df before I knew. The trap is that the test which looked like the evidence links a different translation unit from the one that broke: a green tick answers "the targets CI built compile", which is a different set on a different runner. The section says to ask which target compiles the file (`forward_serve.cpp` is in the serve binary, not in the helper's test), how to find it when you cannot name it (`grep CMakeLists.txt`), and that "the whole `1bit` binary" is an answer rather than a reason to skip the step. Kept out of the command table on purpose: those six all answer questions without a build, and mixing a compile into that list would make the list cost minutes instead of seconds, which is how a checklist stops being run. --- docs/pre-pr-checks.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/docs/pre-pr-checks.md b/docs/pre-pr-checks.md index e4bf8067f..f52058e0a 100644 --- a/docs/pre-pr-checks.md +++ b/docs/pre-pr-checks.md @@ -95,6 +95,23 @@ carried an already-merged commit for the same reason. side drops them; rebase and keep every row `main` has; - **stale and clean** — behind, not destructive: the merge keeps `main`'s rows. Rebase when convenient. +## The one that is not a command: build the target that contains the file you edited + +Nothing above compiles anything, and a green `build` tick does not answer this question either -- it answers "the targets CI built +compile", which is a different set, built by a different runner, from a different checkout. + + engine#2327, 2026-11-13: the image refusal added a 400 body to app/forward_serve.cpp and it was one brace short. The PR's unit + test built and passed -- it covered `npu::message_carries_an_image()`, the *predicate*. The PR merged, `main` did not compile, + and another lane fixed it in 273f6e9df ("serve: main does not compile at the #2327 image refusal") before I knew. + +The trap is that the test which seemed to be the evidence links a different translation unit from the one that broke. Ask which +target compiles the file, not whether the file looks right: + + cmake --build build- --target -j 6 + +`forward_serve.cpp` is in the serve binary, not in the helper's test. If you cannot name the target, `grep` `CMakeLists.txt` for +the file name -- and if the answer is "the whole `1bit` binary", that is the answer, not a reason to skip it. + ## These are not CI rows Every check above runs in CI except `registration_loss_check` and `conflict_triage`, which compare two revisions — a build only