From ef7b303b2c56fa18ef47f690afac16fc2ad97596 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Thu, 12 Nov 2026 18:01:52 -0400 Subject: [PATCH] pr_carry_check: name the other half in the header Review feedback on #2308, and it is the gap I would have wanted closed: this tool asks whether a PR ADDS files that are not its own, and registration_loss_check asks whether it REMOVES lines base still has. A head can pass one and fail the other -- a re-base that takes another lane's files fails this one, one that drops main's rows fails that one -- and a reader who hits only one failure does not learn the other exists. --- tools/ci/pr_carry_check.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/ci/pr_carry_check.py b/tools/ci/pr_carry_check.py index 5bb91be54..1704af7f6 100755 --- a/tools/ci/pr_carry_check.py +++ b/tools/ci/pr_carry_check.py @@ -26,6 +26,13 @@ Refs are things you already fetched (`git fetch origin pull/N/head:refs/pr/N`); this tool never touches the network and never writes the index, so it is safe to run in a worktree someone is using. Exit 0 when every changed path is the PR's own, 1 when it is not, 2 on a usage error. + +**The other half, so you do not have to hit both failures to find both tools.** This asks *"does the PR +ADD files that are not its own?"*. The complement is *"does it REMOVE lines that base still has?"* -- +`tools/ci/registration_loss_check.py`, which is what to run when a branch reads MERGEABLE while quietly +deleting another PR's registrations. A head can pass one and fail the other: a re-base that takes another +lane's files fails this tool, and one that drops main's rows fails that one. Run both on a branch you did +not write. """ import argparse