diff --git a/CMakeLists.txt b/CMakeLists.txt index 13bf9363e..eac988ab6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -133,6 +133,22 @@ file(WRITE ${CMAKE_BINARY_DIR}/generated/hrx_archs.h "static const char* const kHrxGgufArchs[] = {\n${_onebit_archs}};\n") set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${CMAKE_SOURCE_DIR}/registry/architectures.json) set_target_properties(onebit PROPERTIES OUTPUT_NAME 1bit) + +# engine#1993: `1bit` is the OUTPUT NAME, not a target -- the target is `onebit`. With the MAKEFILE generator (CMake's +# default) the output file `1bit` in the build directory makes `--target 1bit` a satisfied FILE rule, so the command prints +# nothing, exits 0 and builds nothing while a stale binary keeps its old timestamp: a typo that succeeds, which is the +# failure this fleet pays for most. With Ninja the same command is not a trap: `1bit` there is the output-file rule of +# `onebit`, so `--target 1bit` rebuilds and relinks the binary (measured, CMake 4.2.3: a touched source, rc 0, new mtime). +# So this refusal is added ONLY for the Makefile generator, and it cannot be added for Ninja at all: a custom target with +# that name is a second rule for an output `onebit` already produces, which ninja rejects outright ("multiple rules generate +# 1bit") and Makefile absorbs as a phony. Deliberately not an alias: an alias that built `onebit` would keep the wrong name +# in everyone's fingers and logs. +if(CMAKE_GENERATOR MATCHES "Makefiles") + add_custom_target(1bit + COMMAND ${CMAKE_COMMAND} -E echo "error: the build target is onebit; 1bit is only its output file name. Nothing was built. Use: cmake --build --target onebit" + COMMAND ${CMAKE_COMMAND} -E false + VERBATIM) +endif() target_link_libraries(onebit PRIVATE nlohmann_json::nlohmann_json httplib::httplib Threads::Threads) # ── The chat-template renderer (engine #963, docs/npu-chat-template.md) ────── diff --git a/tools/hyperloom/custom/README.md b/tools/hyperloom/custom/README.md index df383a805..7725bf2e3 100644 --- a/tools/hyperloom/custom/README.md +++ b/tools/hyperloom/custom/README.md @@ -48,7 +48,7 @@ plus `hl_cli_login.py` and a `launch.sh` wrapper) is gone: upstream now knows th cmake -B ~/wt/hl-engine-build -G Ninja -S ~/wt/hl-engine -DCMAKE_BUILD_TYPE=Release \ -DONEBIT_HRX=ON -DONEBIT_HRX_TOOLCHAIN=/opt/rocm-therock \ -DONEBIT_HRX_LIBHSA=/opt/rocm-therock/lib/python3.14/site-packages/_rocm_sdk_core/lib/libhsa-runtime64.so.1 - cmake --build ~/wt/hl-engine-build -j 4 --target 1bit llama-bench llama-perplexity llama-server + cmake --build ~/wt/hl-engine-build -j 4 --target onebit llama-bench llama-perplexity llama-server ``` The build root is `HL_BUILD` (default `~/wt/hl-engine-build`): `1bit` sits at its top, and the