From f5b6985a90d628b4a4557b7f70d4a34a4f61cc54 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Tue, 10 Nov 2026 03:22:19 -0400 Subject: [PATCH] hrx_build_scope: pin the reason string where it names a file (#1753 review) The self-test compared verdicts only, so the no-line-change reason could go back to claiming CMakeLists.txt for a mode change on a cmake/tests-*.cmake family file and nothing would fail. The new arm asserts the reason names the registration files and does not name CMakeLists.txt. Restoring the pre-#1753 wording makes it fail. Co-Authored-By: Claude Opus 5.5 --- tools/ci/hrx_build_scope.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/ci/hrx_build_scope.py b/tools/ci/hrx_build_scope.py index d7e01e389..944e554f1 100755 --- a/tools/ci/hrx_build_scope.py +++ b/tools/ci/hrx_build_scope.py @@ -266,6 +266,14 @@ def self_test(): ok = got == want print(("ok " if ok else "FAIL ") + f"{name} -> {got}" + ("" if ok else f" (wanted {want}: {why})")) bad += 0 if ok else 1 + # The reason string is this tool's product, and the arms above compare the verdict only (engine#1753's review). The + # no-line-change branch is reached by a mode change on a family file too, since #1744 widened the diff, so it must + # name the registration files and not claim CMakeLists.txt: that wrong wording is what survived #1744 unseen. + got, why = decide(["cmake/tests-gpu-hold.cmake"], "+++ b/cmake/tests-gpu-hold.cmake\n") + ok = got == "full" and "registration file" in why and "CMakeLists.txt" not in why + print(("ok " if ok else "FAIL ") + "a mode-only family file names the registration files, not CMakeLists.txt" + + ("" if ok else f" (got {got}: {why})")) + bad += 0 if ok else 1 g = git_arm() if g is None: print("skip git: no git on PATH, from_git() not exercised")