From 37ba74d79897bb7bf2efde6558522d868d8a6324 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Tue, 10 Nov 2026 03:11:39 -0400 Subject: [PATCH] ci_targets_check: name the add_dependencies route too, because it is the one the tree already uses #1829 added the scope-free route to this message ("fold the cases into a target ci.yml already builds"). engine#1799 then solved the same blocker a different way, and a way the checker already follows: add_dependencies(onebit npu_answer_parser_test) # makes ci.yml's `onebit` build it That is less invasive than folding cases into another binary -- the test keeps its own `add_executable` and its own ctest row -- and it is the precedent `onebit_npu_forward_syntax` already set. `build_closure()` has followed `add_dependencies` since engine#1595, so the only thing that was missing was the message saying so. Four PRs hit this blocker tonight; the message should name the route the tree prefers. Also corrects my own count: with `add_dependencies` listed there are four routes and only the first (naming the target in ci.yml) needs a `.github/workflows/` edit, so the sentence no longer claims "three routes, only the middle one needs no ci.yml edit". Verified: `--self-test` 0 failures (it does not pin the wording); clean tree rc 0; engine#1799's `8cb62c6` (extracted to a scratch root, the drifting shape) still rc 1 and now prints all four routes. --- tools/ci/ci_targets_check.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/ci/ci_targets_check.py b/tools/ci/ci_targets_check.py index cc88d1b53..4ac56efec 100755 --- a/tools/ci/ci_targets_check.py +++ b/tools/ci/ci_targets_check.py @@ -462,10 +462,11 @@ def check(root): where = f" under if({' AND '.join(guards)})" if guards else "" print(f"ci_targets_check: add_test names '{name}'{where}, and ci.yml never builds " f"{'/'.join(sorted(set(need[name])))} -- that test never reaches ctest in the configuration CI " - f"creates (it is not registered, or registered and not built). Three routes, and only the middle one " - f"needs no ci.yml edit: name the target in ci.yml's build list (a `.github/workflows/` edit, so it " - f"needs `workflow` scope), fold these cases into a target ci.yml ALREADY builds (the " - f"tests/npu_pack_import_test.cpp pattern), or drop the test") + f"creates (it is not registered, or registered and not built). Routes, of which only the first needs a " + f"ci.yml edit: name the target in ci.yml's build list (a `.github/workflows/` edit, so it needs " + f"`workflow` scope); make it a build dependency of a target ci.yml builds " + f"(`add_dependencies(onebit )`, which this checker already follows); fold these cases into such " + f"a target (the tests/npu_pack_import_test.cpp pattern); or drop the test") if new: return 1 # A baseline entry that no longer drifts is progress; say so rather than staying silent, so the