From d2cbfc7c3704e10736c0c812bf7b019f6a2acf13 Mon Sep 17 00:00:00 2001 From: bong-water-water-bong Date: Tue, 10 Nov 2026 00:34:35 -0400 Subject: [PATCH] tests: register base_modes_test, and say why anchor_rerun is not a ctest row (engine#1800) Of the eight tests/*.sh #1800 lists as referenced by nothing, the seven gpu_hold_* scripts are registered: they live in cmake/tests-gpu-hold.cmake (moved there by #1699), which the issue's grep of CMakeLists.txt did not read. Two really had no runner on main: * tests/base_modes_test.sh pins the 1bit OS base layer's mode normaliser (scripts/pack-elf.sh, engine#1474): it only NARROWS modes (a 0600 secret stays 0600) and the keep-list keeps /tmp at 1777. Registered as `base_modes`, next to release_check_selftest and in the same shape: no build, no device, no target. * tests/anchor_rerun.sh is an operator measurement, not a test: real GGUFs, an output directory, a 30-minute health window per model, PASS/FAIL printed per model and exit 0 always. Registered, it would skip forever or go green over a FAIL line, so its header now says that instead. Co-Authored-By: Claude Opus 5.5 --- CMakeLists.txt | 5 +++++ tests/anchor_rerun.sh | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7df77955f..ab5a616a9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -208,6 +208,11 @@ add_test(NAME recipes_route COMMAND ${CMAKE_SOURCE_DIR}/tests/recipes_route.sh $ # it is here because nothing else runs it: the rows had 128 assertions and no runner. It names no add_executable, so it # adds nothing to the set of test targets the CI --target list would have to build (the direction-B measurement, #1595). add_test(NAME release_check_selftest COMMAND bash ${CMAKE_SOURCE_DIR}/os/mini/release-check.sh --self-test) +# engine#1800: the 1bit OS base layer's mode normaliser and reporter (scripts/pack-elf.sh, engine#1474), run over a +# crafted tree. Same shape as the row above: no build, no device, no target, so it adds nothing to the CI --target list. +# It was in tests/ with nothing referencing it, so the property it pins (the normaliser only NARROWS modes: a 0600 +# secret stays 0600 and /tmp keeps 1777) had no runner at all. +add_test(NAME base_modes COMMAND bash ${CMAKE_SOURCE_DIR}/tests/base_modes_test.sh ${CMAKE_SOURCE_DIR}) add_test(NAME template_pin COMMAND ${CMAKE_SOURCE_DIR}/tests/template_pin.sh $) add_test(NAME greedy_shortcut COMMAND ${CMAKE_SOURCE_DIR}/tests/greedy_shortcut.sh $) add_test(NAME device_route COMMAND ${CMAKE_SOURCE_DIR}/tests/device_route.sh $) diff --git a/tests/anchor_rerun.sh b/tests/anchor_rerun.sh index 53b67131e..63f623da7 100755 --- a/tests/anchor_rerun.sh +++ b/tests/anchor_rerun.sh @@ -16,6 +16,11 @@ # # Re-run the anchor completion on `1bit serve` for the target models. # usage: anchor_rerun.sh <1bit> : [: ...] +# +# Not a ctest row, on purpose (engine#1800): this is an operator MEASUREMENT, not a pass/fail test. It needs real GGUFs +# and an output directory, allows each model a 30-minute health window, prints PASS/FAIL/SKIP per model and always exits +# 0, so registered it would either skip forever or report green over a FAIL line. Run it by hand, inside a gpu-hold +# ticket when --device names a GPU. set -uo pipefail bin=${1:?usage: anchor_rerun.sh <1bit> : ...}